mirror of
https://we.phorge.it/source/arcanist.git
synced 2024-11-21 22:32:41 +01:00
No description
36de84eeee
Summary: I looked at this quickly to see what was involved and there were only a couple of issues so here's a patch: - On OSX, the "-i" flag does not mean "--mime". Use "--mime" explicitly instead. This is a minor fix which affects only OS X. - I wasn't able to repro the "crazy executables" behavior and think it might have been me messing something up, so nuke it until we see an issue. - Some guid vs phid shenanigans. Differential reads "phid" but arcanist set "guid". We should move toward "phid"; I started using "guid" before I realized it was an overloaded term that also refers to a specific GUID implementation (Microsoft's UUID). Test Plan: Uploaded an image diff, saw images in Differential. Reviewed By: aran Reviewers: jianfeng, jungejason, aran, tuomaspelkonen CC: aran Differential Revision: 466 |
||
|---|---|---|
| bin | ||
| externals | ||
| resources | ||
| scripts | ||
| src | ||
| .arcconfig | ||
| .divinerconfig | ||
| .gitignore | ||
| LICENSE | ||
| README | ||
PROJECT STATUS: CAVEAT EMPTOR This is an unstable preview release. I'm open sourcing some of Facebook's internal tools, but they'll be unstable for at least a couple months. -epriestley WHAT IS ARCANIST? Arcanist is the CLI for Facebook's code review tool, Differential. Since Differential isn't released yet, it may not be terribly useful on its own.