1
0
Fork 0
mirror of https://we.phorge.it/source/arcanist.git synced 2024-11-10 00:42:40 +01:00
phorge-arcanist/src
epriestley 39b3778287 Revenge of the git relative commit default
Summary:
The default of "arc diff" to "arc diff HEAD^" in git is universally confusing to everyone not at Facebook.

Drive the default with configuration instead. Even at Facebook, "origin/trunk" (or whatever) is probably a better default than "HEAD^".

See D863 for the last attempt at this.

NOTE: This is contentious!

Test Plan: Ran "arc diff", got prompted to set a default. Ran "arc diff" from a zero-commit repo, got sensible behavior

Reviewers: btrahan, vrana, nh, jungejason, tuomaspelkonen

Reviewed By: btrahan

CC: aran, epriestley, zeeg, davidreuss

Maniphest Tasks: T651

Differential Revision: https://secure.phabricator.com/D1861
2012-04-02 16:52:20 -07:00
..
branch Use execxLocal() for ArcanistGitAPI 2012-03-02 16:47:34 -08:00
configuration Add an "arc alias" command 2012-02-21 13:16:52 -08:00
difference Add a test case to make sure prefix/suffix intraline diffs work correctly 2012-03-12 18:21:44 -07:00
differential Remove chooseRevision() and DifferentialRevisionRef 2012-03-09 08:57:24 -08:00
docs Reorganize documentation. 2011-05-31 12:14:20 -07:00
events/constant/type Allow modification of the svn commit message via an event listener 2011-11-16 16:40:19 -08:00
exception When a mercurial working copy has uncommitted changes, prompt to include them in "arc diff" 2012-03-19 19:17:10 -07:00
lint Whitespace 2012-03-30 14:55:55 -07:00
parser Use assert_instances_of() 2012-03-29 08:35:49 -07:00
repository Revenge of the git relative commit default 2012-04-02 16:52:20 -07:00
unit Show a better expected vs actual for tests with large output 2012-03-26 09:43:47 -07:00
workflow Revenge of the git relative commit default 2012-04-02 16:52:20 -07:00
workingcopyidentity Finalize Arcanist Classes 2012-01-31 12:07:05 -08:00
__phutil_library_init__.php Initial commit. 2011-01-09 15:22:25 -08:00
__phutil_library_map__.php When a mercurial working copy has uncommitted changes, prompt to include them in "arc diff" 2012-03-19 19:17:10 -07:00