mirror of
https://we.phorge.it/source/arcanist.git
synced 2024-09-20 00:49:11 +02:00
No description
3ad72195bf
Summary: Currently, we prompt the user to mark non-UTF8 files as binary, but don't actually attach the data to the change when they do. This means we don't upload the data, and can't patch it later. A simple reproduction case is to build a test file (I used one with bytes from 1..255): $ # Don't include \0, since Git treats that specially. $ ./echo_every_byte_from_1_to_255_inclusive.erl > example.txt Then add it: $ git add example.txt $ git commit -a -m derp $ arc diff --only HEAD^ You'll be prompted to convert the file to binary: Do you want to mark this file as binary and continue? [Y/n] y Before this patch, that would be followed by: Uploading 0 files... ...which is incorrect; we need to upload the new data. After this patch, this shows: Uploading 1 files... ...which is also incorrect, but only grammatically. Diffs created after this patch apply back cleanly with `arc patch` and restore the file properly. Test Plan: Followed instructions above, restoring a textual binary conversion by using `arc patch`. Reviewers: zeeg, btrahan Reviewed By: btrahan CC: aran Differential Revision: https://secure.phabricator.com/D6815 |
||
|---|---|---|
| bin | ||
| externals | ||
| resources | ||
| scripts | ||
| src | ||
| .arcconfig | ||
| .divinerconfig | ||
| .editorconfig | ||
| .gitignore | ||
| LICENSE | ||
| NOTICE | ||
| README | ||
WHAT IS ARCANIST? Arcanist is the command-line tool for Phabricator. It allows you to interact with Phabricator installs to send code for review, download patches, transfer files, view status, make API calls, and various other things. You can find a complete user guide here: http://www.phabricator.com/docs/phabricator/article/Arcanist_User_Guide.html For more information about Phabricator, see: http://phabricator.org/ LICENSE Arcanist is released under the Apache 2.0 license except as otherwise noted.