1
0
Fork 0
mirror of https://we.phorge.it/source/arcanist.git synced 2024-11-22 06:42:41 +01:00
phorge-arcanist/src/repository/marker
epriestley 85c953ebe4 Fix a PHP 8.1 repository marker issue in Mercurial
Summary:
Ref T13588. "arc-ls-markers" emits a "branch-state" marker so callers can identify which branch is active in the working copy.

This marker doesn't have an associated commit, so trying to generate a display name fails under stricter PHP 8.1 rules when we try to `substr(null, ...)`.

Don't attempt to generate a display name for markers with no commit hash.

Test Plan:
  - Ran `arc branches` under PHP 8.1 in a Mercurial repository.
  - Before: fatal.
  - After: sensible output.

Maniphest Tasks: T13588

Differential Revision: https://secure.phabricator.com/D21825
2022-05-17 16:20:14 -07:00
..
ArcanistGitRepositoryMarkerQuery.php Identify published commits in working copies by using remote configuration 2020-06-30 14:56:34 -07:00
ArcanistMarkerRef.php When saving and restoring local state in Mercurial, also save and restore bookmarks 2020-07-08 15:30:17 -07:00
ArcanistMercurialRepositoryMarkerQuery.php Refactor how Mercurial runs commands that require extensions 2021-07-21 00:40:14 -04:00
ArcanistRepositoryMarkerQuery.php Fix a PHP 8.1 repository marker issue in Mercurial 2022-05-17 16:20:14 -07:00