mirror of
https://we.phorge.it/source/arcanist.git
synced 2025-01-10 06:41:04 +01:00
4181fbde12
Summary: Ref T4954. There was a typo in the original implementation. It wasn't noticed until now because the `getVersion` function isn't really used anywhere. Test Plan: Ran `arc linters` in a repository with `ArcanistJSONLintLinter` configured, noticed that the version number appeared in the output. Reviewers: #blessed_reviewers, epriestley Reviewed By: #blessed_reviewers, epriestley Subscribers: epriestley, Korvin Maniphest Tasks: T4954 Differential Revision: https://secure.phabricator.com/D9160
96 lines
2.2 KiB
PHP
96 lines
2.2 KiB
PHP
<?php
|
|
|
|
/**
|
|
* A linter for JSON files.
|
|
*/
|
|
final class ArcanistJSONLintLinter extends ArcanistExternalLinter {
|
|
|
|
public function getInfoName() {
|
|
return 'JSON Lint';
|
|
}
|
|
|
|
public function getInfoURI() {
|
|
return 'https://github.com/zaach/jsonlint';
|
|
}
|
|
|
|
public function getInfoDescription() {
|
|
return pht('Use `jsonlint` to detect syntax errors in JSON files.');
|
|
}
|
|
|
|
public function getLinterName() {
|
|
return 'JSON';
|
|
}
|
|
|
|
public function getLinterConfigurationName() {
|
|
return 'jsonlint';
|
|
}
|
|
|
|
public function getDefaultBinary() {
|
|
return 'jsonlint';
|
|
}
|
|
|
|
public function getVersion() {
|
|
// NOTE: `jsonlint --version` returns a non-zero exit status.
|
|
list($err, $stdout) = exec_manual(
|
|
'%C --version',
|
|
$this->getExecutableCommand());
|
|
|
|
$matches = array();
|
|
if (preg_match('/^(?P<version>\d+\.\d+\.\d+)$/', $stdout, $matches)) {
|
|
return $matches['version'];
|
|
} else {
|
|
return false;
|
|
}
|
|
}
|
|
|
|
public function getInstallInstructions() {
|
|
return pht('Install jsonlint using `npm install -g jsonlint`.');
|
|
}
|
|
|
|
public function shouldExpectCommandErrors() {
|
|
return true;
|
|
}
|
|
|
|
public function supportsReadDataFromStdin() {
|
|
return true;
|
|
}
|
|
|
|
protected function getMandatoryFlags() {
|
|
return array(
|
|
'--compact',
|
|
);
|
|
}
|
|
|
|
protected function parseLinterOutput($path, $err, $stdout, $stderr) {
|
|
$lines = phutil_split_lines($stderr, false);
|
|
|
|
$messages = array();
|
|
foreach ($lines as $line) {
|
|
$matches = null;
|
|
$match = preg_match(
|
|
'/^(?:(?<path>.+): )?' .
|
|
'line (?<line>\d+), col (?<column>\d+), ' .
|
|
'(?<description>.*)$/',
|
|
$line,
|
|
$matches);
|
|
|
|
if ($match) {
|
|
$message = new ArcanistLintMessage();
|
|
$message->setPath($path);
|
|
$message->setLine($matches['line']);
|
|
$message->setChar($matches['column']);
|
|
$message->setCode($this->getLinterName());
|
|
$message->setDescription(ucfirst($matches['description']));
|
|
$message->setSeverity(ArcanistLintSeverity::SEVERITY_ERROR);
|
|
|
|
$messages[] = $message;
|
|
}
|
|
}
|
|
|
|
if ($err && !$messages) {
|
|
return false;
|
|
}
|
|
|
|
return $messages;
|
|
}
|
|
}
|