epriestley 44e25495ca Raise a lint warning on array_combine(x, x) ... Summary: Suggest array_fuse(). Test Plan: Unit tests, and: $ arc lint --lintall src/unit/engine/phutil/ArcanistPhutilTestCase.php >>> Lint for src/unit/engine/phutil/ArcanistPhutilTestCase.php: Warning (XHP37) array_combine() Unreliable Prior to PHP 5.4, array_combine() fails when given empty arrays. Prefer to write array_combine(x, x) as array_fuse(x). 252 $callable, 253 $exception_class = 'Exception') { 254 return $this->tryTestCases( >>> 255 array_combine(array_keys($map), array_keys($map)), 256 array_values($map), 257 $callable, 258 $exception_class); Reviewers: btrahan, vrana, chad Reviewed By: btrahan CC: aran Differential Revision: https://secure.phabricator.com/D4659		2013-01-25 17:06:49 -08:00
..
engine	Raise a lint warning on array_combine(x, x)	2013-01-25 17:06:49 -08:00
ArcanistUnitTestResult.php	Implement --everything, --json and --ugly flags for arc unit	2012-12-17 12:56:41 -08:00