1
0
Fork 0
mirror of https://we.phorge.it/source/arcanist.git synced 2025-01-24 21:48:20 +01:00
phorge-arcanist/src/lint/linter
Joshua Spence 48d62ed444 Don't use error context from JSHint in linter messages
Summary:
The error context (a.k.a. "original text") as provided by `jshint` is not very useful and actually causes `arc lint` to display the lint message incorrectly.

{F169277}

The underlying problem here is that the error context from `jshint` contains the entire line from the input file rather than just the offending source code.

Test Plan: Ran `arc lint -- webroot/rsrc/js/core/behavior-hovercard.js` (in rP) and verified that the output looked reasonable.

Reviewers: epriestley, #blessed_reviewers

Reviewed By: epriestley, #blessed_reviewers

Subscribers: epriestley, Korvin

Differential Revision: https://secure.phabricator.com/D9675
2014-06-23 10:33:01 +10:00
..
__tests__ Add unit tests for ArcanistPylintLinter. 2014-06-23 03:32:35 +10:00
spelling Lint the ArcanistSpellingDefaultData class. 2014-06-09 11:36:00 -07:00
xhpast Tidying up of linter code. 2014-06-20 18:26:44 +10:00
ArcanistBaseXHPASTLinter.php Tidying up of linter code. 2014-06-20 18:26:44 +10:00
ArcanistChmodLinter.php Add an ArcanistChmodLinter. 2014-05-18 16:57:08 -07:00
ArcanistClosureLinter.php Tidying up of linter code. 2014-06-20 18:26:44 +10:00
ArcanistCoffeeLintLinter.php Update ArcanistCoffeeLintLinter to be compatible with CoffeeLint v1.4.0. 2014-05-18 06:07:35 -07:00
ArcanistConduitLinter.php Remove severity options from some linters. 2014-05-11 19:28:27 -07:00
ArcanistCppcheckLinter.php Fixed the error message when cppcheck isn't installed to not be completely wrong. 2014-05-12 12:58:03 -07:00
ArcanistCpplintLinter.php Warn when accessing deprecated lint config 2014-05-11 18:39:28 -07:00
ArcanistCSharpLinter.php Tidying up of linter code. 2014-06-20 18:26:44 +10:00
ArcanistCSSLintLinter.php Tidying up of linter code. 2014-06-20 18:26:44 +10:00
ArcanistExternalLinter.php Tidying up of linter code. 2014-06-20 18:26:44 +10:00
ArcanistFilenameLinter.php Tidying up of linter code. 2014-06-20 18:26:44 +10:00
ArcanistFlake8Linter.php Tidying up of linter code. 2014-06-20 18:26:44 +10:00
ArcanistFutureLinter.php Made some additional methods of ArcanistLinter and ArcanistExternalLinter final 2014-05-12 09:49:45 -07:00
ArcanistGeneratedLinter.php Remove severity options from some linters. 2014-05-11 19:28:27 -07:00
ArcanistGoLintLinter.php Add an ArcanistGoLintLinter. 2014-05-23 07:59:57 -07:00
ArcanistJscsLinter.php Add an ArcanistJscsLinter. 2014-06-17 06:40:36 +10:00
ArcanistJSHintLinter.php Don't use error context from JSHint in linter messages 2014-06-23 10:33:01 +10:00
ArcanistJSONLinter.php Add a native JSON linter. 2014-06-22 06:41:22 +10:00
ArcanistJSONLintLinter.php Apply various linter fixes. 2014-06-10 11:02:42 -07:00
ArcanistLesscLinter.php Tidying up of linter code. 2014-06-20 18:26:44 +10:00
ArcanistLinter.php Tidying up of linter code. 2014-06-20 18:26:44 +10:00
ArcanistMergeConflictLinter.php Tidying up of linter code. 2014-06-20 18:26:44 +10:00
ArcanistNoLintLinter.php Remove severity options from some linters. 2014-05-11 19:28:27 -07:00
ArcanistPEP8Linter.php Tidying up of linter code. 2014-06-20 18:26:44 +10:00
ArcanistPhpcsLinter.php Tidying up of linter code. 2014-06-20 18:26:44 +10:00
ArcanistPhutilLibraryLinter.php Tidying up of linter code. 2014-06-20 18:26:44 +10:00
ArcanistPhutilXHPASTLinter.php Move the "ragged classtree edge" linter rule to ArcanistPhutilXHPASTLinter. 2014-06-18 01:28:40 +10:00
ArcanistPuppetLintLinter.php Provide more help text for arc linters 2014-05-11 16:16:45 -07:00
ArcanistPyFlakesLinter.php Don't support severity customization in pyflakes 2014-05-20 12:44:55 -07:00
ArcanistPyLintLinter.php Tidying up of linter code. 2014-06-20 18:26:44 +10:00
ArcanistRubyLinter.php Tidying up of linter code. 2014-06-20 18:26:44 +10:00
ArcanistScriptAndRegexLinter.php Tidying up of linter code. 2014-06-20 18:26:44 +10:00
ArcanistSpellingLinter.php Tidying up of linter code. 2014-06-20 18:26:44 +10:00
ArcanistTextLinter.php Tidying up of linter code. 2014-06-20 18:26:44 +10:00
ArcanistXHPASTLinter.php Minor fix for the ArcanistXHPASTLinter. 2014-06-23 01:56:57 +10:00
ArcanistXMLLinter.php Tidying up of linter code. 2014-06-20 18:26:44 +10:00
reporter.js Don't use error context from JSHint in linter messages 2014-06-23 10:33:01 +10:00