mirror of
https://we.phorge.it/source/arcanist.git
synced 2025-01-26 06:28:19 +01:00
4a3d829223
Summary: We have some linters that trigger based on the path name in the tree (some rules apply in some dirs and not others). The changes in D6798 caused all the paths to appear to be outside the tree, so allow for passing a fake through from those test cases that are sensitive to this. We also have a test for the copyright linter, and that needs to read settings from the .arcconfig file. The change to faking a working copy meant that this config option was effectively unset, so add a way to pass the entire arcconfig through from the tests that need it. Lastly, the logic to skip deleted files needs to be special cased when we're faking paths like this: if we've added data for a file in the testable engine, we should also consider that file as existing. Test Plan: `arc unit --everything` here, and passing our tests in our repo over there. Reviewers: epriestley, mareksapota Reviewed By: epriestley CC: Korvin, aran Differential Revision: https://secure.phabricator.com/D6841
34 lines
650 B
PHP
34 lines
650 B
PHP
<?php
|
|
|
|
/**
|
|
* Lint engine for use in constructing test cases. See
|
|
* @{class:ArcanistLinterTestCase}.
|
|
*
|
|
* @group testcase
|
|
*/
|
|
final class UnitTestableArcanistLintEngine extends ArcanistLintEngine {
|
|
|
|
protected $linters = array();
|
|
|
|
public function addLinter($linter) {
|
|
$this->linters[] = $linter;
|
|
return $this;
|
|
}
|
|
|
|
public function addFileData($path, $data) {
|
|
$this->fileData[$path] = $data;
|
|
return $this;
|
|
}
|
|
|
|
public function pathExists($path) {
|
|
if (idx($this->fileData, $path)) {
|
|
return true;
|
|
}
|
|
return parent::pathExists($path);
|
|
}
|
|
|
|
protected function buildLinters() {
|
|
return $this->linters;
|
|
}
|
|
|
|
}
|