mirror of
https://we.phorge.it/source/arcanist.git
synced 2024-11-09 00:12:40 +01:00
8e0e07664a
Summary: Ref T13098. Historically, Phabricator was split into three parts: - Phabricator, the server. - Arcanist, the client. - libphutil, libraries shared between the client and server. One imagined use case for this was that `libphutil` might become a general-purpose library that other projects would use. However, this didn't really happen, and it seems unlikely to at this point: Phabricator has become a relatively more sophisticated application platform; we didn't end up seeing or encouraging much custom development; what custom development there is basically embraces all of Phabricator since there are huge advantages to doing so; and a general "open source is awful" sort of factor here in the sense that open source users often don't have goals well aligned to our goals. Turning "arc" into a client platform and building package management solidify us in this direction of being a standalone platform, not a standalone utility library. Phabricator also depends on `arcanist/`. If it didn't, there would be a small advantage to saying "shared code + client for client, shared code + server for server", but there's no such distinction and it seems unlikely that one will ever exist. Even if it did, I think this has little value. Nowadays, I think this separation has no advantages for us and one significant cost: it makes installing `arcanist` more difficult for end-users. This will need some more finesssing (Phabricator will need some changes for compatibility, and a lot of stuff that still says "libphutil" or "phutil" may eventually want to say "arcanist"), and some stuff (like xhpast) is probably straight-up broken right now and needs some tweaking, but I don't anticipate any major issues here. There was never anything particularly magical about libphutil as a separate standalone library. Test Plan: Ran `arc`, it gets about as far as it did before. Reviewers: amckinley Reviewed By: amckinley Maniphest Tasks: T13098 Differential Revision: https://secure.phabricator.com/D19688
59 lines
1.4 KiB
PHP
Executable file
59 lines
1.4 KiB
PHP
Executable file
#!/usr/bin/env php
|
|
<?php
|
|
|
|
require_once dirname(__FILE__).'/../__init_script__.php';
|
|
|
|
$args = new PhutilArgumentParser($argv);
|
|
$args->setTagline(pht('test %s class', 'InteractiveEditor'));
|
|
$args->setSynopsis(<<<EOHELP
|
|
**interactive_editor.php** [__options__]
|
|
Edit some content via the InteractiveEditor class. This script
|
|
makes it easier to test changes to InteractiveEditor, which is
|
|
difficult to unit test.
|
|
EOHELP
|
|
);
|
|
$args->parseStandardArguments();
|
|
$args->parse(
|
|
array(
|
|
array(
|
|
'name' => 'fallback',
|
|
'param' => 'editor',
|
|
'help' => pht('Set the fallback editor.'),
|
|
),
|
|
array(
|
|
'name' => 'line',
|
|
'short' => 'l',
|
|
'param' => 'number',
|
|
'help' => pht('Open at line number __number__.'),
|
|
),
|
|
array(
|
|
'name' => 'name',
|
|
'param' => 'filename',
|
|
'help' => pht('Set edited file name.'),
|
|
),
|
|
));
|
|
|
|
if ($args->getArg('help')) {
|
|
$args->printHelpAndExit();
|
|
}
|
|
|
|
$editor = new PhutilInteractiveEditor(
|
|
pht("The wizard quickly\njinxed the gnomes\nbefore they vaporized."));
|
|
|
|
$name = $args->getArg('name');
|
|
if ($name) {
|
|
$editor->setName($name);
|
|
}
|
|
|
|
$line = $args->getArg('line');
|
|
if ($line) {
|
|
$editor->setLineOffset($line);
|
|
}
|
|
|
|
$fallback = $args->getArg('fallback');
|
|
if ($fallback) {
|
|
$editor->setFallbackEditor($fallback);
|
|
}
|
|
|
|
$result = $editor->editInteractively();
|
|
echo pht('Edited Text:')."\n{$result}\n";
|