mirror of
https://we.phorge.it/source/arcanist.git
synced 2024-12-01 19:22:41 +01:00
4fdb87761b
Summary: Fixes T1277. The rules we use to figure out the root of the working copy get a bunch of edge cases wrong right now. A particularly troublesome one is when a user has a `/.arcconfig` or `/home/.arcconfig` or similar, which raises a completely useless and confusing error message (T1277). Rewrite these rules to get all the edge cases correct and do reasonable things in the presence of stray `.arcconfig`. There are a bunch of comments, but basically the algorithm is: - From the top, go down one directory at a time until we find ".svn", ".git", or ".hg". - In Subversion, keep going down looking for ".arcconfig". In Git and Mercurial, look for ".arcconfig" only in the same directory. - Now that we've figured out the VCS root (where the ".vcs" directory is) and the project root (where the ".arcconfig" file is, if it exists), build an identity. This logic was also spread across three different places. Consolidate it into one and add some logging so we can figure out what's going wrong if users run into trouble. Test Plan: - Ran VCS (`arc list`) and non-VCS (`arc help`) commands in Git, Mercurial, and Subversions roots and subdirectories. Also ran them in non-VCS directories. Ran them with and without .arcconfig. All the outputs seemed completely reasonable. Reviewers: btrahan Reviewed By: btrahan CC: aran Maniphest Tasks: T1277 Differential Revision: https://secure.phabricator.com/D7686 |
||
|---|---|---|
| .. | ||
| __tests__ | ||
| ArcanistGitAPI.php | ||
| ArcanistMercurialAPI.php | ||
| ArcanistRepositoryAPI.php | ||
| ArcanistSubversionAPI.php | ||