mirror of
https://we.phorge.it/source/arcanist.git
synced 2024-11-22 06:42:41 +01:00
No description
5150252f91
Summary: Adds a secret, undoucmented "encoding" key to ".arcconfig" which makes a very half-hearted effort to convert encodings. This is probably good enough that Differential can be used for code review, but there will be issues with 'arc patch', 'arc export', paste, maybe conduit stuff, Diffusion, and whatever else I haven't thought of. This also doesn't store the original encoding so anything converted like this won't reasonably be able to be made to work with all that stuff in the future. See T452 for a broader discussion of the issues involved. Test Plan: Short circuited the UTF-8 detection to always fail, had my files "converted" from ISO-8859-1 to UTF-8. @davidreuss: you can test this by applying this patch to arcanist/, adding '"encoding" : "ISO-8859-1"' to your .arcconfig, touching some non-ASCII file, and then running "arc diff". Reviewers: davidreuss, jungejason, tuomaspelkonen, aran Reviewed By: davidreuss CC: aran, davidreuss, epriestley, nshamg123 Differential Revision: 812 |
||
|---|---|---|
| bin | ||
| externals | ||
| resources | ||
| scripts | ||
| src | ||
| .arcconfig | ||
| .divinerconfig | ||
| .gitignore | ||
| LICENSE | ||
| README | ||
PROJECT STATUS: CAVEAT EMPTOR This is an unstable preview release. I'm open sourcing some of Facebook's internal tools, but they'll be unstable for at least a couple months. -epriestley WHAT IS ARCANIST? Arcanist is the CLI for Facebook's code review tool, Differential. Since Differential isn't released yet, it may not be terribly useful on its own.