Bob Trahan 51cccfd21e Add "nocommit" git-only flag to arc patch workflow ... Summary: without "nocommit" we commit the patch to the working copy. add the nocommit flag and this commit does not happen. making this happen required adding revisionID to arc bundle to fetch the proper commit message. if we can't get a commit message -- suppose the fetch fails or the source is self::SOURCE_PATCH, we ask the user for the commit message on the command line Test Plan: git reset --hard <SOME_REV> arc patch DX, where this got us to <SOME_REV + 1> observe correct patch committed with correct commit message in working copy git reset --hard <SOME_REV> arc patch --nocommit DX, where this got us to <SOME_REV + 1> observe correct patch landed BUT NOT committed. note "commit message" does not exist since there isn't a commit...! git diff HEAD^1 > ~/file.patch git reset --hard HEAD^1 arc patch --patch ~/file.patch observe prompted for commit message and patch committed with commit message i typed in Reviewers: epriestley Reviewed By: epriestley CC: aran Maniphest Tasks: T479 Differential Revision: https://secure.phabricator.com/D1450		2012-01-18 15:25:54 -08:00
..
__init__.php	Unify arguments for 'arc lint', 'arc unit'	2012-01-10 10:42:22 -08:00
ArcanistBaseWorkflow.php	Add "nocommit" git-only flag to arc patch workflow	2012-01-18 15:25:54 -08:00