mirror of
https://we.phorge.it/source/arcanist.git
synced 2024-11-25 16:22:42 +01:00
No description
54c3ad316e
Summary: - When you try to "arc patch" a change which adds or removes a trailing newline or alters a file with a trailing newline near the newline, the patch fails because we fail to reconstuct the "\ No newline at end of file" line. - We don't currently record enough information about these diffs to reconstruct them with a sensible amount of effort. Store the "\ No newline at end of file" line instead of just a flag. - There are some special rules for these lines; implement them. NOTE: This causes some display glitching in Differential, but nothing major; I'll fix that in a followup patch. Test Plan: - Created a diff which added a trailing newline, removed a trailing newline, and altered a file without a trailing newline near the end of the file. - Verified that the git version of this patch and the 'arc export --git' version of this patch are (essentially) identical. - Verified that "arc diff" + "arc patch" can apply these changes. Reviewers: btrahan Reviewed By: btrahan CC: aran, epriestley Maniphest Tasks: T533 Differential Revision: https://secure.phabricator.com/D1810 |
||
---|---|---|
bin | ||
externals | ||
resources | ||
scripts | ||
src | ||
.arcconfig | ||
.divinerconfig | ||
.gitignore | ||
LICENSE | ||
README |
WHAT IS ARCANIST? Arcanist is the command-line tool for Phabricator. It allows you to interact with Phabricator installs to send code for review, download patches, transfer files, view status, make API calls, and various other things. You can find a complete user guide here: http://www.phabricator.com/docs/phabricator/article/Arcanist_User_Guide.html For more information about Phabricator, see: http://phabricator.org/