mirror of
https://we.phorge.it/source/arcanist.git
synced 2024-11-22 14:52:40 +01:00
d477df00eb
Summary: As mentioned in the [[https://secure.phabricator.com/book/phabcontrib/article/php_coding_standards/ | Phabricator PHP coding standards]], the `eval` function should be avoided. There is some good discussion on [[http://stackoverflow.com/questions/951373/when-is-eval-evil-in-php | StackOverflow]] as well. Having said that, instead of hardcoding `eval()`, I have generalised this enough to allow a set of "blacklisted" functions to be defined with `xhpast.blacklisted.function` in the `.arclint` file. Test Plan: Added a test case. Reviewers: #blessed_reviewers, epriestley Reviewed By: #blessed_reviewers, epriestley Subscribers: Korvin, epriestley Differential Revision: https://secure.phabricator.com/D10686
72 lines
1.4 KiB
Text
72 lines
1.4 KiB
Text
{
|
|
"exclude": [
|
|
"(^externals/)",
|
|
"(\\.lint-test$)"
|
|
],
|
|
"linters": {
|
|
"chmod": {
|
|
"type": "chmod"
|
|
},
|
|
"filename": {
|
|
"type": "filename"
|
|
},
|
|
"generated": {
|
|
"type": "generated"
|
|
},
|
|
"json": {
|
|
"type": "json",
|
|
"include": [
|
|
"(^resources/arclint/.*\\.arclint\\.example$)",
|
|
"(^\\.arcconfig$)",
|
|
"(^\\.arclint$)",
|
|
"(\\.json$)"
|
|
]
|
|
},
|
|
"merge-conflict": {
|
|
"type": "merge-conflict"
|
|
},
|
|
"nolint": {
|
|
"type": "nolint"
|
|
},
|
|
"phutil-library": {
|
|
"type": "phutil-library",
|
|
"include": "(\\.php$)"
|
|
},
|
|
"phutil-xhpast": {
|
|
"type": "phutil-xhpast",
|
|
"include": "(\\.php$)"
|
|
},
|
|
"spelling": {
|
|
"type": "spelling",
|
|
"exclude": "(resources/spelling/.*\\.json$)"
|
|
},
|
|
"text": {
|
|
"type": "text",
|
|
"exclude": [
|
|
"(^\\.arclint$)"
|
|
]
|
|
},
|
|
"text-without-length": {
|
|
"type": "text",
|
|
"severity": {
|
|
"3": "disabled"
|
|
},
|
|
"include": [
|
|
"(^\\.arclint$)"
|
|
]
|
|
},
|
|
"xhpast": {
|
|
"type": "xhpast",
|
|
"include": "(\\.php$)",
|
|
"severity": {
|
|
"16": "advice",
|
|
"34": "error"
|
|
},
|
|
"xhpast.blacklisted.function": {
|
|
"eval": "The eval() function should be avoided. It is potentially unsafe and makes debugging more difficult."
|
|
},
|
|
"xhpast.php-version": "5.2.3",
|
|
"xhpast.php-version.windows": "5.3.0"
|
|
}
|
|
}
|
|
}
|