mirror of
https://we.phorge.it/source/arcanist.git
synced 2024-11-22 23:02:41 +01:00
45c2152988
Summary: Ref T10895. NOTE: I'm going to land this and other changes to a new `experimental` branch until `arc` is more substantially rebuilt, since everything I touch feels like it requires me to rebuild 30 other things first. Currently, many `arc` workflows are unnecessarily slow because they call `conduit.connect` on startup. There's no need to do this with the modern way the API works, and we've generally moved away from explicit version testing to more granular capability testing on specific workflows. Additionally, some workflows like `arc patch` are huge messes (see T11434) because they're trying to run in anonymous mode but it doesn't really work with all the upfront stuff Conduit does now. It's not possible, in the general case, for a workflow to know upfront if it needs Conduit or not. And: - `ArcanistWorkflow` has piles of Conduit logic, but should not. - Pooling Conduit requests isn't very easy. - There's a lot of general cruft around the workflow. - We should drop certificate support. This pulls out Conduit into a separate on-demand class with modern support, future pooling, less cruft, inline handling of login issues, and generally less garbage. Also adds an `--anonymous` flag, mostly to make testing easier. Test Plan: Ran `arc browse`, used `--anonymous` and `--trace`, fiddled with credentials, got approximatley the same behavior that mainline `arc` has. Reviewers: chad, avivey Reviewed By: avivey Subscribers: avivey Maniphest Tasks: T10895 Differential Revision: https://secure.phabricator.com/D16921
14 lines
295 B
Text
14 lines
295 B
Text
# NOTE: Thinking about adding files created by your operating system, IDE,
|
|
# or text editor here? Don't! Add them to your per-user .gitignore instead.
|
|
|
|
# Diviner
|
|
/docs/
|
|
/.divinercache/
|
|
|
|
# libphutil
|
|
/src/.phutil_module_cache
|
|
/src/.cache
|
|
|
|
# User extensions
|
|
/externals/includes/*
|
|
/src/extensions/*
|