revi-archive/phorge-arcanist
1
0
Fork 0
mirror of https://we.phorge.it/source/arcanist.git synced 2024-12-23 14:00:55 +01:00
Code Issues Releases Wiki Activity
No description
162 commits 5 branches 7 tags 12 MiB
PHP 61.4%
C++ 37%
Yacc 1.1%
Python 0.3%
Lex 0.2%
Find a file
epriestley 65c0d07935 Add PHP lint check for expressions which can be statically evaluated 
Summary:
This is pretty coarse and could be refined, but I often do this when testing:

  lang=diff
  - if (some_complicated_condition())
  + if (true || some_complicated_condition())

aran has caught me not only doing it but sending out diffs with it like 30
times. Catch it in lint instead.

Test Plan:
Unit test, added a "true || $junk" to the code and linted it.

Reviewed By: aran
Reviewers: aran, jungejason, tuomaspelkonen, pad
CC: aran
Differential Revision: 447
2011-06-13 10:17:43 -07:00
bin Initial commit. 2011-01-09 15:22:25 -08:00
externals arc lint: fix/enable PEP8 linter 2011-05-18 16:47:23 -07:00
resources Basic 'shell-complete' workflow. 2011-01-17 20:18:27 -08:00
scripts Make sure 'id' and 'idx' are not marked as builtin functions? 2011-05-29 02:35:26 -07:00
src Add PHP lint check for expressions which can be statically evaluated 2011-06-13 10:17:43 -07:00
.arcconfig Detect library conflicts in Arcanist and raise a very specific error message 2011-05-19 11:32:53 -07:00
.divinerconfig Updated .divinerconfig. 2011-03-02 15:25:45 -08:00
.gitignore Add .divinercache to .gitignore. 2011-05-25 18:51:52 -07:00
LICENSE Initial commit. 2011-01-09 15:22:25 -08:00
README Initial commit. 2011-01-09 15:22:25 -08:00

README 

PROJECT STATUS: CAVEAT EMPTOR

This is an unstable preview release. I'm open sourcing some of Facebook's
internal tools, but they'll be unstable for at least a couple months.
-epriestley


WHAT IS ARCANIST?

Arcanist is the CLI for Facebook's code review tool, Differential. Since
Differential isn't released yet, it may not be terribly useful on its own.