1
0
Fork 0
mirror of https://we.phorge.it/source/arcanist.git synced 2024-12-25 15:00:57 +01:00
phorge-arcanist/scripts
jungejason 6910fd77a4 Use getcwd() which is more reliable than $_SERVER['PWD']
Summary:
in arcanist we are using $_SERVER['PWD'], but in some cases it
is not returning the correct result. For example, when I'm using
PhpStorm (an php IDE) to launch the script, $_SERVER['PWD'] returns the
path of the binary of the IDE:
/home/jungejason/tools/PhpStorm-107.658/bin, not the path where arcanist
is at. getcwd() returns the correct value.

One difference between getcwd() and $_SERVER['PWD'] is that getcwd()
resolves symlink where $_SERVER['PWD'] does not. From what I can see,
using realpath should work.

Test Plan:
* ran arcanist as normal and it worked;
* run arcanist in PhpStorm and it worked.
* created a symlink pointing to the repository inside which
I ran the arc command, and it worked.
* created a symlink pointing to arcanist project, run `.
* resources/shell/bash-completion`  and it worked

Reviewers: epriestley

Reviewed By: epriestley

CC: aran, epriestley

Differential Revision: https://secure.phabricator.com/D1285
2011-12-24 15:05:13 -08:00
..
__init_script__.php @include_once libphutil, not @require_once 2011-10-20 14:35:34 -07:00
arcanist.php Use getcwd() which is more reliable than $_SERVER['PWD'] 2011-12-24 15:05:13 -08:00
phutil_analyzer.php Fix phutil_analyzer bug on interface dependency creation 2011-08-10 12:01:30 -03:00
phutil_mapper.php 'arc liberate', convenience wrapper for various libphutil operations 2011-05-17 09:53:19 -07:00