1
0
Fork 0
mirror of https://we.phorge.it/source/arcanist.git synced 2024-12-01 19:22:41 +01:00
phorge-arcanist/src/repository/api
Javier Arteaga 6ecb3fb87d Avoid parsing git "remote show" using "ls-remote"
Summary:
Ref T5554. This makes git remote URL detection locale-agnostic.

The previously suggested `git config remote.origin.url` command does
almost the same, but does not support the URL rewriting features in
git-config (`url.<base>.insteadOf`).

This one does, although it has the unintuitive behavior of just printing
the passed remote name when the remote does not exist, or even when
called outside a git repo.

Test Plan:
* Switched to non-english locale in which git has a translation.
* Ran `arc which` on the Arcanist repo. It could not determine the remote URI.
* Applied patch, `arc which` found the URI.

Reviewers: #blessed_reviewers, epriestley

Reviewed By: #blessed_reviewers, epriestley

Subscribers: johnny-bit, Korvin

Maniphest Tasks: T5554

Differential Revision: https://secure.phabricator.com/D13983
2015-08-24 04:51:03 -07:00
..
__tests__ Rename ArcanistPhutilTestCase to PhutilTestCase and Remove ArcanistTestCase 2015-05-20 09:40:24 +10:00
ArcanistGitAPI.php Avoid parsing git "remote show" using "ls-remote" 2015-08-24 04:51:03 -07:00
ArcanistMercurialAPI.php Various linter fixes 2015-08-11 22:35:40 +10:00
ArcanistRepositoryAPI.php Extend from Phobject 2015-06-15 15:47:33 +10:00
ArcanistSubversionAPI.php Remove arcanist projects from working copy code 2015-05-26 07:08:56 +10:00