1
0
Fork 0
mirror of https://we.phorge.it/source/arcanist.git synced 2025-01-22 20:51:09 +01:00
phorge-arcanist/src
James Rhodes 75737c6d89 Prevent detailed code coverage from accessing missing report.
Summary:
Fixes T3856.

Detailed code coverage iterates over all of the files with changes in the current repository, however the code coverage tool might not generate a report for all changed files in the repository, and this would result in an undefined index error.

As an additional bonus, since changes to binary files won't be reported by code coverage tools, this also prevents binary data from being outputted to the console.

Test Plan:
Change a binary file in a repository and run a code coverage tool.  The binary file should be reported as 0% code coverage, but the file contents should not be rendered to the console.

Change a code file that is not covered by a code coverage tool and run code coverage.  The file should be reported as 0% code coverage, and the file contents should not be displayed.

Reviewers: epriestley

Reviewed By: epriestley

CC: Korvin, aran

Maniphest Tasks: T3856

Differential Revision: https://secure.phabricator.com/D7051
2013-09-20 09:18:02 -07:00
..
configuration Pass global CA bundle to HTTPSFuture, T3668 2013-08-04 08:21:35 -07:00
difference Compute UTF8 string differences correctly, accounting for combining characters 2013-05-23 14:38:09 -07:00
differential Delete license headers from files 2012-11-05 11:16:24 -08:00
docs Make the "this is technical documentation" message of "Arcanist Overview" more clear 2012-08-10 11:37:30 -07:00
events/constant Dispatch an event in arc land right before pushing a revision 2013-03-08 18:32:36 -08:00
exception Delete license headers from files 2012-11-05 11:16:24 -08:00
extensions Changes to Arcanist for libphutil "extensions/" 2013-04-22 14:38:49 -07:00
hgdaemon Fix dynamic string usage as safe input 2013-02-02 16:28:15 -08:00
infrastructure/testing Delete license headers from files 2012-11-05 11:16:24 -08:00
lint Correct capitalization of "new" in lint 2013-09-12 13:01:25 -07:00
parser When converting a file to a binary, populate the binary's data 2013-08-27 09:34:30 -07:00
repository Ignore errors from "svn upgrade" in unit tests 2013-09-11 21:23:30 -07:00
unit Perform case-insensitive check for PHPUnit test finder to not return original file 2013-09-19 15:14:58 -07:00
workflow Prevent detailed code coverage from accessing missing report. 2013-09-20 09:18:02 -07:00
workingcopyidentity Simplify and demuck some of the linter test cases 2013-08-22 16:02:41 -07:00
__phutil_library_init__.php Delete license headers from files 2012-11-05 11:16:24 -08:00
__phutil_library_map__.php Merge pull request #90 from dcramer/pytest 2013-09-06 11:49:56 -07:00