1
0
Fork 0
mirror of https://we.phorge.it/source/arcanist.git synced 2024-11-21 22:32:41 +01:00
phorge-arcanist/scripts
epriestley 768a125b58 Enrich arc configuration and add stronger typing
Summary:
See <https://github.com/facebook/arcanist/issues/45>

Currently, when the user types `arc set-config x false`, we set it as the string "false", which is usually not desirable. We have some steps toward typed config already, but expand on what we have and move as much stuff as possible into it, including all the config settings that aren't currently documented (there are still some lint-specific and project-specific settings not present here, but this is most of it).

Also make the `phutil_libraries` key a legacy name for `load`, and `immutable_history` a legacy name for `history.immutable`. Generally the goal here is to make config simpler and bring it more in-line with Git/Mercurial, which use dotted hierarchies.

I'll add some documentation here but I think most of the changes should be fairly straightforward.

Test Plan:
  - `arc set-config history.immutable on` (And similar -- sets to boolean true.)
  - `arc set-config history.immutable off` (And similar -- sets to boolean false.)
  - `arc set-config history.immutable derp` (And similar -- raises exception.)
  - `arc set-config history.immutable ''` (And similar -- removes setting value.)
  - `arc set-config --show`
  - `arc get-config`
  - `arc get-config base`

Reviewers: dschleimer, bos, btrahan, vrana

Reviewed By: dschleimer

CC: aran

Maniphest Tasks: T1546

Differential Revision: https://secure.phabricator.com/D3045
2012-07-25 18:37:09 -07:00
..
hgdaemon Add various flags to the HgProxy daemons 2012-06-26 11:00:26 -07:00
lib Add mb_* functions to the external function list 2012-07-11 16:55:21 -07:00
repository Use binary safe diff in arc diff 2012-07-03 13:33:28 -07:00
__init_script__.php Use pht() for plural 2012-06-19 15:16:52 -07:00
arcanist.php Enrich arc configuration and add stronger typing 2012-07-25 18:37:09 -07:00
breakout.py Create a mysterious new workflow 2012-07-22 14:39:53 -07:00
php_extension_functions.txt Add mb_* functions to the external function list 2012-07-11 16:55:21 -07:00
phutil_rebuild_map.php Bump symbol cache version from v2 -> v3 2012-06-14 12:02:27 -07:00
phutil_symbols.php Include common extensions in symbol mapper 2012-06-12 12:54:26 -07:00
update_compat_info.php Warn about PHP 5.3 only functions and parameters 2012-06-22 15:52:10 -07:00