mirror of
https://we.phorge.it/source/arcanist.git
synced 2025-01-08 13:51:01 +01:00
768e1a56bc
Summary:
See rARC3ffed59bd7. Currently, when a unit test includes a syntax error, it is raised in an unclear way ("error at line 10, char 1: XHP1 Unknown lint message!").
This is because each test case only activates rules it wants to test, so we lose the ID/name for the syntax message. However, we always want to test this and the lint engine can always raise it.
To get a better error message, include it unconditionally. So a test for rule `X` really tests two rules: syntax, and `X`.
Test Plan:
Ran `arc unit` at HEAD, got a better test failure:
```
FAIL ArcanistCallTimePassByReferenceXHPASTLinterRuleTestCase::testLinter
In 'call-time-pass-by-reference.lint-test', expected lint to raise error on line 10 at char 8, but no error was raised. Actually raised:
error at line 10, char 1: XHP1 PHP Syntax Error!
```
NOTE: This doesn't pass tests yet, it just makes the test failure easier to understand. I'll see about fixing the test in the next change.
Reviewers: chad, richardvanvelzen
Reviewed By: richardvanvelzen
Differential Revision: https://secure.phabricator.com/D15819
|
||
|---|---|---|
| .. | ||
| __tests__ | ||
| exception | ||
| standards | ||
| xhpast | ||
| ArcanistBaseXHPASTLinter.php | ||
| ArcanistChmodLinter.php | ||
| ArcanistClosureLinter.php | ||
| ArcanistCoffeeLintLinter.php | ||
| ArcanistComposerLinter.php | ||
| ArcanistCppcheckLinter.php | ||
| ArcanistCpplintLinter.php | ||
| ArcanistCSharpLinter.php | ||
| ArcanistCSSLintLinter.php | ||
| ArcanistExternalLinter.php | ||
| ArcanistFilenameLinter.php | ||
| ArcanistFlake8Linter.php | ||
| ArcanistFutureLinter.php | ||
| ArcanistGeneratedLinter.php | ||
| ArcanistGoLintLinter.php | ||
| ArcanistHLintLinter.php | ||
| ArcanistInlineHTMLXHPASTLinterRule.php | ||
| ArcanistJscsLinter.php | ||
| ArcanistJSHintLinter.php | ||
| ArcanistJSONLinter.php | ||
| ArcanistJSONLintLinter.php | ||
| ArcanistLesscLinter.php | ||
| ArcanistLinter.php | ||
| ArcanistMergeConflictLinter.php | ||
| ArcanistNoLintLinter.php | ||
| ArcanistPEP8Linter.php | ||
| ArcanistPhpcsLinter.php | ||
| ArcanistPhpLinter.php | ||
| ArcanistPhutilLibraryLinter.php | ||
| ArcanistPuppetLintLinter.php | ||
| ArcanistPyFlakesLinter.php | ||
| ArcanistPyLintLinter.php | ||
| ArcanistRuboCopLinter.php | ||
| ArcanistRubyLinter.php | ||
| ArcanistScriptAndRegexLinter.php | ||
| ArcanistSpellingLinter.php | ||
| ArcanistTextLinter.php | ||
| ArcanistXHPASTLinter.php | ||
| ArcanistXMLLinter.php | ||
| reporter.js | ||