mirror of
https://we.phorge.it/source/arcanist.git
synced 2024-11-26 00:32:41 +01:00
77a9c18140
Summary: Fixes T4163. Re-word the question so its the same as in "arc diff". Draw the line though and don't automagically do anything if the user says "Y", 'cuz amending / adding files last minute in 'arc land' and other workflows is batshit insane. Assuming infinite growth in the future, I think its best to get this language consistent now. I changed the shouldAmend member variable to a shouldAmend() function with a static inside. Previously shouldAmend was getting set as a side effect and it was kind of weird. I thought maybe it was written this way because the calls to the vcs are a little slow or something. As such, I figured caching it in the static was a good idea? Didn't seem awful but maybe a premature optimization with whatever the performance reality turns out to be. Also a modest amount of bonus pht. Test Plan: this very diff. i'm going to arc land it laters too. Reviewers: epriestley Reviewed By: epriestley Subscribers: chad, epriestley, Korvin Maniphest Tasks: T4163 Differential Revision: https://secure.phabricator.com/D8753 |
||
|---|---|---|
| .. | ||
| configuration | ||
| difference | ||
| differential | ||
| docs/book | ||
| events/constant | ||
| exception | ||
| extensions | ||
| hgdaemon | ||
| infrastructure/testing | ||
| lint | ||
| parser | ||
| repository | ||
| unit | ||
| workflow | ||
| workingcopyidentity | ||
| __phutil_library_init__.php | ||
| __phutil_library_map__.php | ||