1
0
Fork 0
mirror of https://we.phorge.it/source/arcanist.git synced 2024-11-08 07:52:39 +01:00
phorge-arcanist/scripts
epriestley 7bb8dbabce Reduce the strength of "arc executing on arc" from an error to a warning
Summary:
See PHI13. This was introduced a very, very long time ago in D311 and D312, and I think T168 was the original report.

It prevents `arc` from being used in some semi-reasonable (maybe?) automation workflows where you're hooking some version of "Land Revision" up to `arc land`. This isn't necessarily the right approach, but I think the concession here to make this work is small.

Running `arc` against another copy of `arc` makes `arc unit` not work, but we provide a good error message. Most other `arc` operations still work correctly.

All of these situations are bizarre edge cases but I think we can safely warn and continue here. Even if we revert this behavior later, almost no one should be affected, since this essentially only impacts users developing `arc` itself.

Test Plan: Ran one copy of `arc` against another, saw a warning instead of an error. `arc unit` failed, but with a good error.

Reviewers: chad, jmeador

Reviewed By: jmeador

Differential Revision: https://secure.phabricator.com/D18264
2017-07-21 12:09:59 -07:00
..
hgdaemon phtize some strings 2015-01-06 23:15:50 +11:00
repository Simplify diff exit code handling. 2015-12-13 02:35:07 -08:00
__init_script__.php phtize a bunch more strings 2015-05-22 17:09:56 +10:00
arcanist.php Reduce the strength of "arc executing on arc" from an error to a warning 2017-07-21 12:09:59 -07:00
breakout.py Use python2 instead of python in arc anoid shebang` 2016-03-05 14:29:46 -08:00