revi-archive/phorge-arcanist
1
0
Fork 0
mirror of https://we.phorge.it/source/arcanist.git synced 2025-01-09 22:31:02 +01:00
Code Issues Releases Wiki Activity
phorge-arcanist/src/lint/linter
History
Joshua Spence 8244b3582a Improve behavior for detecting the failure to parse external linter output 
Summary:
Currently, a lot of `ArcanistExternalLinter` subclasses have something like this:

```lang=php
if ($err && !$messages) {
  return false;
}
```

We can avoid this code duplication by moving this check to the `ArcanistExternalLinter` class.

Test Plan: `arc unit`

Reviewers: #blessed_reviewers, epriestley

Reviewed By: #blessed_reviewers, epriestley

Subscribers: Korvin, epriestley

Differential Revision: https://secure.phabricator.com/D11321
2015-05-22 07:30:17 +10:00
..
__tests__ Add linter rule for invalid modifiers 2015-05-20 09:45:13 +10:00
exception Move linter exception classes to src/lint/linter/exception 2015-01-12 06:46:23 +11:00
xhpast Rename ArcanistPhutilTestCase to PhutilTestCase and Remove ArcanistTestCase 2015-05-20 09:40:24 +10:00
ArcanistBaseXHPASTLinter.php Allow getXHPASTTreeForPath to return the tree for an arbitrary path 2015-05-21 15:08:39 +10:00
ArcanistChmodLinter.php Add unit tests for ArcanistChmodLinter 2015-01-15 06:58:11 +11:00
ArcanistClosureLinter.php Remove support for passing data via STDIN 2015-05-05 20:55:49 +10:00
ArcanistCoffeeLintLinter.php Improve behavior for detecting the failure to parse external linter output 2015-05-22 07:30:17 +10:00
ArcanistCppcheckLinter.php Remove deprecated linter configuration 2015-05-21 07:01:37 +10:00
ArcanistCpplintLinter.php Improve behavior for detecting the failure to parse external linter output 2015-05-22 07:30:17 +10:00
ArcanistCSharpLinter.php pht all the things 2015-05-13 21:00:53 +10:00
ArcanistCSSLintLinter.php Remove deprecated linter configuration 2015-05-21 07:01:37 +10:00
ArcanistExternalLinter.php Improve behavior for detecting the failure to parse external linter output 2015-05-22 07:30:17 +10:00
ArcanistFilenameLinter.php Fix visibility of various ArcanistLinter methods 2015-01-07 07:36:07 +11:00
ArcanistFlake8Linter.php Improve behavior for detecting the failure to parse external linter output 2015-05-22 07:30:17 +10:00
ArcanistFutureLinter.php Split large path lists into blocks when linting 2015-04-22 05:15:57 -07:00
ArcanistGeneratedLinter.php pht all the things 2015-05-13 21:00:53 +10:00
ArcanistGoLintLinter.php pht all the things 2015-05-13 21:00:53 +10:00
ArcanistHLintLinter.php pht all the things 2015-05-13 21:00:53 +10:00
ArcanistJscsLinter.php Improve behavior for detecting the failure to parse external linter output 2015-05-22 07:30:17 +10:00
ArcanistJSHintLinter.php Remove deprecated linter configuration 2015-05-21 07:01:37 +10:00
ArcanistJSONLinter.php Minor improvements to ArcanistJSONLinter 2015-01-12 06:40:40 +11:00
ArcanistJSONLintLinter.php Improve behavior for detecting the failure to parse external linter output 2015-05-22 07:30:17 +10:00
ArcanistLesscLinter.php Improve behavior for detecting the failure to parse external linter output 2015-05-22 07:30:17 +10:00
ArcanistLinter.php Remove deprecated linter configuration 2015-05-21 07:01:37 +10:00
ArcanistMergeConflictLinter.php Minor reordering of functions 2014-09-22 18:42:41 +10:00
ArcanistNoLintLinter.php Remove severity options from some linters. 2014-05-11 19:28:27 -07:00
ArcanistPEP8Linter.php Improve behavior for detecting the failure to parse external linter output 2015-05-22 07:30:17 +10:00
ArcanistPhpcsLinter.php Remove deprecated linter configuration 2015-05-21 07:01:37 +10:00
ArcanistPhpLinter.php pht all the things 2015-05-13 21:00:53 +10:00
ArcanistPhutilLibraryLinter.php Allow ArcanistPhutilLibraryLinter to run with an out-of-date XHPAST binary 2015-02-03 08:01:11 +11:00
ArcanistPhutilXHPASTLinter.php Move the getFunctionCalls method to ArcanistBaseXHPASTLinter 2015-05-20 07:00:29 +10:00
ArcanistPuppetLintLinter.php Improve behavior for detecting the failure to parse external linter output 2015-05-22 07:30:17 +10:00
ArcanistPyFlakesLinter.php Improve behavior for detecting the failure to parse external linter output 2015-05-22 07:30:17 +10:00
ArcanistPyLintLinter.php Improve behavior for detecting the failure to parse external linter output 2015-05-22 07:30:17 +10:00
ArcanistRuboCopLinter.php pht all the things 2015-05-13 21:00:53 +10:00
ArcanistRubyLinter.php Improve behavior for detecting the failure to parse external linter output 2015-05-22 07:30:17 +10:00
ArcanistScriptAndRegexLinter.php Remove deprecated linter configuration 2015-05-21 07:01:37 +10:00
ArcanistSpellingLinter.php Provide a getProjectRoot method for ArcanistLinter 2015-05-20 09:16:36 +10:00
ArcanistTextLinter.php Move LINT_NO_COMMIT from ArcanistTextLinter to a new linter 2015-01-04 16:20:32 +11:00
ArcanistXHPASTLinter.php Remove "commit hook mode" workarounds for ArcanistXHPASTLinter 2015-05-21 15:08:39 +10:00
ArcanistXMLLinter.php pht all the things 2015-05-13 21:00:53 +10:00
reporter.js Don't use error context from JSHint in linter messages 2014-06-23 10:33:01 +10:00