mirror of
https://we.phorge.it/source/arcanist.git
synced 2024-11-25 00:02:40 +01:00
No description
857f08ae47
Summary: This is sort of a guess. In D357, arc has gone crazy and removed a bunch of 'utils' dependencies for gc3. I think this is because his HPHP/i has them marked as builtins. However, I don't have an HPHP/i build (and probably don't have the fortitude to build it outside of a Facebook environment, I spent about two hours on it at one point and got maybe 25% of the way through the build process before running into things I didn't know how to resolve) so I'm not sure this is the issue. No one else's diffs have exhibited this problem eitehr, so I'm not confident this is actually the problem or solution. gc3, can you apply this locally to a copy of arcanist and then run 'arc lint' (or 'arc lint --apply-patches') on your commit and see if it restores all the libphutil/utils requirements? Test Plan: unable, see summary Added 'array_keys' to this blacklist and verified the technical behavior of the patch is correct by var_dump()'ing builtins. Reviewed By: gc3 Reviewers: gc3, tuomaspelkonen, jungejason, aran CC: aran, gc3, epriestley Differential Revision: 361 |
||
|---|---|---|
| bin | ||
| externals | ||
| resources | ||
| scripts | ||
| src | ||
| .arcconfig | ||
| .divinerconfig | ||
| .gitignore | ||
| LICENSE | ||
| README | ||
PROJECT STATUS: CAVEAT EMPTOR This is an unstable preview release. I'm open sourcing some of Facebook's internal tools, but they'll be unstable for at least a couple months. -epriestley WHAT IS ARCANIST? Arcanist is the CLI for Facebook's code review tool, Differential. Since Differential isn't released yet, it may not be terribly useful on its own.