mirror of
https://we.phorge.it/source/arcanist.git
synced 2025-01-25 05:58:20 +01:00
67b6bed92e
Summary: Various tidying up of linting code. Test Plan: `arc lint` and `arc unit` still pass. Reviewers: chad, epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9625
102 lines
2.3 KiB
PHP
102 lines
2.3 KiB
PHP
<?php
|
|
|
|
/**
|
|
* Uses `ruby` to detect various errors in Ruby code.
|
|
*/
|
|
final class ArcanistRubyLinter extends ArcanistExternalLinter {
|
|
|
|
public function getInfoURI() {
|
|
return 'https://www.ruby-lang.org/';
|
|
}
|
|
|
|
public function getInfoName() {
|
|
return pht('Ruby');
|
|
}
|
|
|
|
public function getInfoDescription() {
|
|
return pht('Use `ruby` to check for syntax errors in Ruby source files.');
|
|
}
|
|
|
|
public function getLinterName() {
|
|
return 'RUBY';
|
|
}
|
|
|
|
public function getLinterConfigurationName() {
|
|
return 'ruby';
|
|
}
|
|
|
|
public function getDefaultBinary() {
|
|
$prefix = $this->getDeprecatedConfiguration('lint.ruby.prefix');
|
|
if ($prefix !== null) {
|
|
$ruby_bin = $prefix.'ruby';
|
|
}
|
|
|
|
return 'ruby';
|
|
}
|
|
|
|
public function getVersion() {
|
|
list($stdout) = execx('%C --version', $this->getExecutableCommand());
|
|
|
|
$matches = array();
|
|
$regex = '/^ruby (?P<version>\d+\.\d+\.\d+)p\d+/';
|
|
if (preg_match($regex, $stdout, $matches)) {
|
|
return $matches['version'];
|
|
} else {
|
|
return false;
|
|
}
|
|
}
|
|
|
|
public function getInstallInstructions() {
|
|
return pht('Install `ruby` from <http://www.ruby-lang.org/>.');
|
|
}
|
|
|
|
public function supportsReadDataFromStdin() {
|
|
return true;
|
|
}
|
|
|
|
public function shouldExpectCommandErrors() {
|
|
return true;
|
|
}
|
|
|
|
protected function getMandatoryFlags() {
|
|
// -w: turn on warnings
|
|
// -c: check syntax
|
|
return array('-w', '-c');
|
|
}
|
|
|
|
protected function parseLinterOutput($path, $err, $stdout, $stderr) {
|
|
$lines = phutil_split_lines($stderr, false);
|
|
|
|
$messages = array();
|
|
foreach ($lines as $line) {
|
|
$matches = null;
|
|
|
|
if (!preg_match('/(.*?):(\d+): (.*?)$/', $line, $matches)) {
|
|
continue;
|
|
}
|
|
|
|
foreach ($matches as $key => $match) {
|
|
$matches[$key] = trim($match);
|
|
}
|
|
|
|
$code = head(explode(',', $matches[3]));
|
|
|
|
$message = new ArcanistLintMessage();
|
|
$message->setPath($path);
|
|
$message->setLine($matches[2]);
|
|
$message->setCode($this->getLinterName());
|
|
$message->setName(pht('Syntax Error'));
|
|
$message->setDescription($matches[3]);
|
|
$message->setSeverity($this->getLintMessageSeverity($code));
|
|
|
|
$messages[] = $message;
|
|
}
|
|
|
|
if ($err && !$messages) {
|
|
return false;
|
|
}
|
|
|
|
return $messages;
|
|
}
|
|
|
|
}
|