mirror of
https://we.phorge.it/source/arcanist.git
synced 2024-11-22 14:52:40 +01:00
6910fd77a4
Summary: in arcanist we are using $_SERVER['PWD'], but in some cases it is not returning the correct result. For example, when I'm using PhpStorm (an php IDE) to launch the script, $_SERVER['PWD'] returns the path of the binary of the IDE: /home/jungejason/tools/PhpStorm-107.658/bin, not the path where arcanist is at. getcwd() returns the correct value. One difference between getcwd() and $_SERVER['PWD'] is that getcwd() resolves symlink where $_SERVER['PWD'] does not. From what I can see, using realpath should work. Test Plan: * ran arcanist as normal and it worked; * run arcanist in PhpStorm and it worked. * created a symlink pointing to the repository inside which I ran the arc command, and it worked. * created a symlink pointing to arcanist project, run `. * resources/shell/bash-completion` and it worked Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1285 |
||
---|---|---|
.. | ||
__init_script__.php | ||
arcanist.php | ||
phutil_analyzer.php | ||
phutil_mapper.php |