1
0
Fork 0
mirror of https://we.phorge.it/source/arcanist.git synced 2024-11-26 16:52:40 +01:00
phorge-arcanist/scripts/utils/directory_fixture.php
epriestley 8e0e07664a [Wilds] Remove libphutil
Summary:
Ref T13098. Historically, Phabricator was split into three parts:

  - Phabricator, the server.
  - Arcanist, the client.
  - libphutil, libraries shared between the client and server.

One imagined use case for this was that `libphutil` might become a general-purpose library that other projects would use.

However, this didn't really happen, and it seems unlikely to at this point: Phabricator has become a relatively more sophisticated application platform; we didn't end up seeing or encouraging much custom development; what custom development there is basically embraces all of Phabricator since there are huge advantages to doing so; and a general "open source is awful" sort of factor here in the sense that open source users often don't have goals well aligned to our goals.

Turning "arc" into a client platform and building package management solidify us in this direction of being a standalone platform, not a standalone utility library.

Phabricator also depends on `arcanist/`. If it didn't, there would be a small advantage to saying "shared code + client for client, shared code + server for server", but there's no such distinction and it seems unlikely that one will ever exist. Even if it did, I think this has little value.

Nowadays, I think this separation has no advantages for us and one significant cost: it makes installing `arcanist` more difficult for end-users.

This will need some more finesssing (Phabricator will need some changes for compatibility, and a lot of stuff that still says "libphutil" or "phutil" may eventually want to say "arcanist"), and some stuff (like xhpast) is probably straight-up broken right now and needs some tweaking, but I don't anticipate any major issues here. There was never anything particularly magical about libphutil as a separate standalone library.

Test Plan: Ran `arc`, it gets about as far as it did before.

Reviewers: amckinley

Reviewed By: amckinley

Maniphest Tasks: T13098

Differential Revision: https://secure.phabricator.com/D19688
2018-09-21 16:38:53 -07:00

94 lines
2.3 KiB
PHP
Executable file

#!/usr/bin/env php
<?php
require_once dirname(__FILE__).'/../__init_script__.php';
$args = new PhutilArgumentParser($argv);
$args->setTagline(pht('edit directory fixtures'));
$args->setSynopsis(<<<EOHELP
**directory_fixture.php** __file__ --create
Create a new directory fixture.
**directory_fixture.php** __file__
Edit an existing directory fixture.
EOHELP
);
$args->parseStandardArguments();
$args->parse(array(
array(
'name' => 'create',
'help' => pht('Create a new fixture.'),
),
array(
'name' => 'read-only',
'help' => pht('Do not save changes made to the fixture.'),
),
array(
'name' => 'files',
'wildcard' => true,
),
));
$is_create = $args->getArg('create');
$is_read_only = $args->getArg('read-only');
$console = PhutilConsole::getConsole();
$files = $args->getArg('files');
if (count($files) !== 1) {
throw new PhutilArgumentUsageException(
pht('Specify exactly one file to create or edit.'));
}
$file = head($files);
if ($is_create) {
if (Filesystem::pathExists($file)) {
throw new PhutilArgumentUsageException(
pht(
'File "%s" already exists, so you can not %s it.',
$file,
'--create'));
}
$fixture = PhutilDirectoryFixture::newEmptyFixture();
} else {
if (!Filesystem::pathExists($file)) {
throw new PhutilArgumentUsageException(
pht(
'File "%s" does not exist! Use %s to create a new fixture.',
$file,
'--create'));
}
$fixture = PhutilDirectoryFixture::newFromArchive($file);
}
$console->writeOut(
"%s\n\n",
pht('Spawning an interactive shell. Working directory is:'));
$console->writeOut(
" %s\n\n",
$fixture->getPath());
if ($is_read_only) {
$console->writeOut(
"%s\n",
pht('Exit the shell when done (this fixture is read-only).'));
} else {
$console->writeOut(
"%s\n",
pht('Exit the shell after making changes.'));
}
$err = phutil_passthru('cd %s && sh', $fixture->getPath());
if ($err) {
$console->writeOut(
"%s\n",
pht('Shell exited with error %d, discarding changes.', $err));
exit($err);
} else if ($is_read_only) {
$console->writeOut(
"%s\n",
pht('Invoked in read-only mode, discarding changes.'));
} else {
$console->writeOut("%s\n", pht('Updating archive...'));
$fixture->saveToArchive($file);
$console->writeOut("%s\n", pht('Done.'));
}