mirror of
https://we.phorge.it/source/arcanist.git
synced 2024-11-27 09:12:40 +01:00
8e0e07664a
Summary: Ref T13098. Historically, Phabricator was split into three parts: - Phabricator, the server. - Arcanist, the client. - libphutil, libraries shared between the client and server. One imagined use case for this was that `libphutil` might become a general-purpose library that other projects would use. However, this didn't really happen, and it seems unlikely to at this point: Phabricator has become a relatively more sophisticated application platform; we didn't end up seeing or encouraging much custom development; what custom development there is basically embraces all of Phabricator since there are huge advantages to doing so; and a general "open source is awful" sort of factor here in the sense that open source users often don't have goals well aligned to our goals. Turning "arc" into a client platform and building package management solidify us in this direction of being a standalone platform, not a standalone utility library. Phabricator also depends on `arcanist/`. If it didn't, there would be a small advantage to saying "shared code + client for client, shared code + server for server", but there's no such distinction and it seems unlikely that one will ever exist. Even if it did, I think this has little value. Nowadays, I think this separation has no advantages for us and one significant cost: it makes installing `arcanist` more difficult for end-users. This will need some more finesssing (Phabricator will need some changes for compatibility, and a lot of stuff that still says "libphutil" or "phutil" may eventually want to say "arcanist"), and some stuff (like xhpast) is probably straight-up broken right now and needs some tweaking, but I don't anticipate any major issues here. There was never anything particularly magical about libphutil as a separate standalone library. Test Plan: Ran `arc`, it gets about as far as it did before. Reviewers: amckinley Reviewed By: amckinley Maniphest Tasks: T13098 Differential Revision: https://secure.phabricator.com/D19688
53 lines
1.4 KiB
C++
53 lines
1.4 KiB
C++
#pragma once
|
|
|
|
#include <stack>
|
|
#include <string>
|
|
|
|
#include "astnode.hpp"
|
|
|
|
class yy_extra_type {
|
|
public:
|
|
yy_extra_type() {
|
|
first_lineno = 0;
|
|
lineno = 1;
|
|
terminated = false;
|
|
last_token = -1;
|
|
insert_token = -1;
|
|
heredoc_yyleng = -1;
|
|
list_size = 0;
|
|
pushStack();
|
|
}
|
|
|
|
size_t first_lineno; // line number before scanning the current token
|
|
size_t lineno; // current line number being scanned.
|
|
std::string error; // description of error (if terminated true)
|
|
bool terminated; // becomes true when the parser terminates with an error
|
|
int last_token; // the last token to be returned by the scanner
|
|
int insert_token; // insert this token without reading from buffer
|
|
size_t heredoc_yyleng; // last length of yytext while scanning
|
|
std::string heredoc_label; // heredoc sentinel label
|
|
unsigned int list_size;
|
|
|
|
xhpast::token_list_t token_list;
|
|
|
|
void pushStack() {
|
|
tag_stack.push_front(std::deque<std::string>());
|
|
}
|
|
|
|
protected:
|
|
std::deque<std::deque<std::string> > tag_stack;
|
|
};
|
|
|
|
#define YYSTYPE xhpast::Node *
|
|
#define YY_HEADER_EXPORT_START_CONDITIONS
|
|
#define YY_EXTRA_TYPE yy_extra_type*
|
|
|
|
#include "parser.yacc.hpp"
|
|
#ifndef FLEX_SCANNER
|
|
#include "scanner.lex.hpp"
|
|
#endif
|
|
|
|
int xhpparse(void*, YYSTYPE *);
|
|
void xhp_new_push_state(int s, struct yyguts_t* yyg);
|
|
void xhp_new_pop_state(struct yyguts_t* yyg);
|
|
void xhp_set_state(int s, struct yyguts_t* yyg);
|