1
0
Fork 0
mirror of https://we.phorge.it/source/arcanist.git synced 2024-11-26 00:32:41 +01:00
phorge-arcanist/src/workflow
epriestley 92b29f53f3 Rename "getWorkingCopy()" to "getWorkingCopyIdentity()" in Arcanist
Summary:
Depends on D21074. Ref T13490. Ref T11968. Before toolsets, Arcanist has a "WorkingCopyIdentity" object. After toolsets, it has a "WorkingCopy" object.

Most workflows don't access either one, so make a slightly-breaking API change to simplify the transition.

  - "getWorkingCopy()" now returns a modern object (a "WorkingCopy").
  - "getWorkingCopyIdentity()" now returns an older object (a "WorkingCopyIdentity").

This isn't backward-compatible, but out-of-date code should get an explicit failure with clear resolution steps.

Test Plan: Ran "arc lint", "arc branch", and a few other commands. Grepped for "getWorkingCopy()".

Maniphest Tasks: T13490, T11968

Differential Revision: https://secure.phabricator.com/D21075
2020-04-10 04:24:29 -07:00
..
exception pht all the things 2015-05-13 21:00:53 +10:00
ArcanistAmendWorkflow.php pht all the things 2015-05-13 21:00:53 +10:00
ArcanistAnoidWorkflow.php Port "arc weld" and "arc anoid" to Toolsets workflows, plus minor fixes 2020-02-16 09:16:24 -08:00
ArcanistBackoutWorkflow.php Strip tips out of commit messages from arc backout 2016-04-02 07:26:02 -07:00
ArcanistBookmarkWorkflow.php Minor linter fixes 2015-05-15 07:09:30 +10:00
ArcanistBranchWorkflow.php Minor linter fixes 2015-05-15 07:09:30 +10:00
ArcanistCallConduitWorkflow.php Use phutil_json_decode instead of json_decode 2015-05-04 22:36:14 +10:00
ArcanistCloseRevisionWorkflow.php When "arc close-revision --finalize ..." skips closing a revision, print a message 2019-11-18 20:31:51 -08:00
ArcanistCloseWorkflow.php Fix two "implode()" order issues arising from wilds/experimental collapse 2020-02-23 08:34:30 -08:00
ArcanistCommitWorkflow.php Various translation improvements 2015-11-02 21:31:04 +11:00
ArcanistCoverWorkflow.php Various translation improvements 2015-11-02 21:31:04 +11:00
ArcanistDiffWorkflow.php Run ls-files from the root of the directory 2020-03-25 14:23:53 -07:00
ArcanistDownloadWorkflow.php Fix two minor issues with "arc download" 2017-04-28 07:45:25 -07:00
ArcanistExportWorkflow.php Remove call to "arcanist.projectinfo" from arc export 2015-05-25 18:31:09 +10:00
ArcanistFeatureWorkflow.php Rename "getWorkingCopy()" to "getWorkingCopyIdentity()" in Arcanist 2020-04-10 04:24:29 -07:00
ArcanistFlagWorkflow.php Linter fixes 2015-12-07 21:35:34 +11:00
ArcanistGetConfigWorkflow.php Rename "getWorkingCopy()" to "getWorkingCopyIdentity()" in Arcanist 2020-04-10 04:24:29 -07:00
ArcanistInstallCertificateWorkflow.php Added a warning prompt if the user tries to use an API cert instead of a CLI cert 2016-08-25 11:34:34 -04:00
ArcanistLandWorkflow.php Update "arc help land" to reference Perforce support 2019-10-28 11:25:32 -07:00
ArcanistLiberateWorkflow.php Port "arc weld" and "arc anoid" to Toolsets workflows, plus minor fixes 2020-02-16 09:16:24 -08:00
ArcanistLintersWorkflow.php Fix missing whitespace in arc linters --help message 2017-08-04 13:12:59 -07:00
ArcanistLintWorkflow.php Rename "getWorkingCopy()" to "getWorkingCopyIdentity()" in Arcanist 2020-04-10 04:24:29 -07:00
ArcanistListWorkflow.php Improve arc's handling of dirty submodules in Git 2015-09-21 12:40:06 -07:00
ArcanistPasteWorkflow.php pht all the things 2015-05-13 21:00:53 +10:00
ArcanistPatchWorkflow.php Update "arcanist/" for "topological" API changes 2019-06-20 16:05:21 -07:00
ArcanistPhrequentWorkflow.php Improve arc's handling of dirty submodules in Git 2015-09-21 12:40:06 -07:00
ArcanistRevertWorkflow.php pht all the things 2015-05-13 21:00:53 +10:00
ArcanistSetConfigWorkflow.php Add back pht()s and tsprintf()s to arg set-config 2017-02-16 11:08:45 +00:00
ArcanistStartWorkflow.php Fix errors found by PHPStan 2017-02-16 13:54:43 +00:00
ArcanistStopWorkflow.php Fix errors found by PHPStan 2017-02-16 13:54:43 +00:00
ArcanistTasksWorkflow.php Fix errors found by PHPStan 2017-02-16 13:54:43 +00:00
ArcanistTimeWorkflow.php Minor tidying of ArcanistPhrequentWorkflow classes 2015-02-01 21:49:53 +11:00
ArcanistTodoWorkflow.php pht all the things 2015-05-13 21:00:53 +10:00
ArcanistUnitWorkflow.php Rename "getWorkingCopy()" to "getWorkingCopyIdentity()" in Arcanist 2020-04-10 04:24:29 -07:00
ArcanistUpgradeWorkflow.php Update the "WorkingCopy" API and create a fallback "Filesystem" working copy 2020-04-08 09:22:43 -07:00
ArcanistUploadWorkflow.php Update "arc upload" for Toolsets 2020-02-26 08:22:18 -08:00
ArcanistWeldWorkflow.php Require "--" as an argument terminator when running noninteractively 2020-02-16 09:16:51 -08:00
ArcanistWhichWorkflow.php Make callsigns optional in arcanist 2016-03-15 03:58:46 +00:00
ArcanistWorkflow.php Rename "getWorkingCopy()" to "getWorkingCopyIdentity()" in Arcanist 2020-04-10 04:24:29 -07:00