mirror of
https://we.phorge.it/source/arcanist.git
synced 2025-01-10 06:41:04 +01:00
7870e7f2e4
Summary: Ref T2039. Addresses two issues: - Issues a warning for use of config which is deprecated by `.arclint`. - We no longer require an engine to be present for these linters, so `arc linters` doesn't fatal if they aren't configured. Test Plan: - Ran `arc linters` in a repo with no JSHint. - Ran `arc linters` in a repo with junk in .arcconfig and got a warning when it was read. Verified it still took effect. Reviewers: chad, btrahan, joshuaspence Reviewed By: joshuaspence Subscribers: epriestley Maniphest Tasks: T2039 Differential Revision: https://secure.phabricator.com/D9058
122 lines
3.2 KiB
PHP
122 lines
3.2 KiB
PHP
<?php
|
|
|
|
/**
|
|
* Uses "CSS Lint" to detect checkstyle errors in css code.
|
|
*/
|
|
final class ArcanistCSSLintLinter extends ArcanistExternalLinter {
|
|
|
|
public function getInfoName() {
|
|
return 'CSSLint';
|
|
}
|
|
|
|
public function getInfoURI() {
|
|
return 'http://csslint.net';
|
|
}
|
|
|
|
public function getInfoDescription() {
|
|
return pht(
|
|
'Use `csslint` to detect issues with CSS source files.');
|
|
}
|
|
|
|
public function getLinterName() {
|
|
return 'CSSLint';
|
|
}
|
|
|
|
public function getLinterConfigurationName() {
|
|
return 'csslint';
|
|
}
|
|
|
|
public function getMandatoryFlags() {
|
|
return array(
|
|
'--format=lint-xml',
|
|
'--quiet',
|
|
);
|
|
}
|
|
|
|
public function getDefaultFlags() {
|
|
return $this->getDeprecatedConfiguration('lint.csslint.options', array());
|
|
}
|
|
|
|
public function getDefaultBinary() {
|
|
return $this->getDeprecatedConfiguration('lint.csslint.bin', 'csslint');
|
|
}
|
|
|
|
public function getVersion() {
|
|
list($stdout) = execx('%C --version', $this->getExecutableCommand());
|
|
|
|
$matches = array();
|
|
if (preg_match('/^v(?P<version>\d+\.\d+\.\d+)$/', $stdout, $matches)) {
|
|
return $matches['version'];
|
|
} else {
|
|
return false;
|
|
}
|
|
}
|
|
|
|
public function getInstallInstructions() {
|
|
return pht('Install CSSLint using `npm install -g csslint`.');
|
|
}
|
|
|
|
public function shouldExpectCommandErrors() {
|
|
return true;
|
|
}
|
|
|
|
protected function parseLinterOutput($path, $err, $stdout, $stderr) {
|
|
$report_dom = new DOMDocument();
|
|
$ok = @$report_dom->loadXML($stdout);
|
|
|
|
if (!$ok) {
|
|
return false;
|
|
}
|
|
|
|
$files = $report_dom->getElementsByTagName('file');
|
|
$messages = array();
|
|
foreach ($files as $file) {
|
|
foreach ($file->childNodes as $child) {
|
|
if (!($child instanceof DOMElement)) {
|
|
continue;
|
|
}
|
|
|
|
$data = $this->getData($path);
|
|
$lines = explode("\n", $data);
|
|
$name = $child->getAttribute('reason');
|
|
$severity = ($child->getAttribute('severity') == 'warning')
|
|
? ArcanistLintSeverity::SEVERITY_WARNING
|
|
: ArcanistLintSeverity::SEVERITY_ERROR;
|
|
|
|
$message = new ArcanistLintMessage();
|
|
$message->setPath($path);
|
|
$message->setLine($child->getAttribute('line'));
|
|
$message->setChar($child->getAttribute('char'));
|
|
$message->setCode('CSSLint');
|
|
$message->setDescription($child->getAttribute('reason'));
|
|
$message->setSeverity($severity);
|
|
|
|
if ($child->hasAttribute('line') && $child->getAttribute('line') > 0) {
|
|
$line = $lines[$child->getAttribute('line') - 1];
|
|
$text = substr($line, $child->getAttribute('char') - 1);
|
|
$message->setOriginalText($text);
|
|
}
|
|
|
|
$messages[] = $message;
|
|
}
|
|
}
|
|
|
|
return $messages;
|
|
}
|
|
|
|
protected function getLintCodeFromLinterConfigurationKey($code) {
|
|
|
|
// NOTE: We can't figure out which rule generated each message, so we
|
|
// can not customize severities. I opened a pull request to add this
|
|
// ability; see:
|
|
//
|
|
// https://github.com/stubbornella/csslint/pull/409
|
|
|
|
throw new Exception(
|
|
pht(
|
|
"CSSLint does not currently support custom severity levels, because ".
|
|
"rules can't be identified from messages in output. ".
|
|
"See Pull Request #409."));
|
|
}
|
|
|
|
}
|