1
0
Fork 0
mirror of https://we.phorge.it/source/arcanist.git synced 2024-09-21 01:18:50 +02:00
phorge-arcanist/src
epriestley a0d4430271 Detect use of f()[0] in lint
Summary: XHPAST doesn't currently parse most PHP 5.4 stuff, but it does parse this. Warn about it.

Test Plan:
Unit tests, and:

   Error  (XHP35) Use Of PHP 5.4 Features
    The f()[...] syntax was not introduced until PHP 5.4, but this codebase
    targets an earlier version of PHP. You can rewrite this expression using
    idx().

             365   public function lintPHP54Features($root) {
             366
             367     if (false) {
    >>>      368       id()[0];
                            ^
             369     }
             370

Reviewers: alanh, vrana

Reviewed By: alanh

CC: aran

Differential Revision: https://secure.phabricator.com/D3291
2012-08-15 04:36:50 -07:00
..
configuration Fix doc links 2012-08-10 14:46:08 -07:00
difference Upgrade arcanist to libphutil v2 2012-05-30 14:22:59 -07:00
differential Move files in Arcanist one level up 2012-06-01 11:56:00 -07:00
docs Make the "this is technical documentation" message of "Arcanist Overview" more clear 2012-08-10 11:37:30 -07:00
events/constant arcanist: add postponed linter support 2012-07-11 18:09:05 -07:00
exception Move files in Arcanist one level up 2012-06-01 11:56:00 -07:00
hgdaemon Add various flags to the HgProxy daemons 2012-06-26 11:00:26 -07:00
lint Detect use of f()[0] in lint 2012-08-15 04:36:50 -07:00
parser Implement base85 in a 32-bit safe way, without bcmath 2012-08-12 19:21:33 -07:00
repository Speedup arc branch 2012-07-18 18:01:44 -07:00
unit Depend on events when attaching Diff ID to postponed unit tests 2012-08-08 12:04:15 -07:00
workflow Pass lint and unit results to diff created event 2012-08-13 14:57:18 -07:00
workingcopyidentity Enrich arc configuration and add stronger typing 2012-07-25 18:37:09 -07:00
__phutil_library_init__.php Initial commit. 2011-01-09 15:22:25 -08:00
__phutil_library_map__.php Add an arc flag workflow 2012-08-03 12:00:54 -07:00