1
0
Fork 0
mirror of https://we.phorge.it/source/arcanist.git synced 2024-12-11 08:06:12 +01:00
phorge-arcanist/scripts/test/progress_bar.php
epriestley 8e0e07664a [Wilds] Remove libphutil
Summary:
Ref T13098. Historically, Phabricator was split into three parts:

  - Phabricator, the server.
  - Arcanist, the client.
  - libphutil, libraries shared between the client and server.

One imagined use case for this was that `libphutil` might become a general-purpose library that other projects would use.

However, this didn't really happen, and it seems unlikely to at this point: Phabricator has become a relatively more sophisticated application platform; we didn't end up seeing or encouraging much custom development; what custom development there is basically embraces all of Phabricator since there are huge advantages to doing so; and a general "open source is awful" sort of factor here in the sense that open source users often don't have goals well aligned to our goals.

Turning "arc" into a client platform and building package management solidify us in this direction of being a standalone platform, not a standalone utility library.

Phabricator also depends on `arcanist/`. If it didn't, there would be a small advantage to saying "shared code + client for client, shared code + server for server", but there's no such distinction and it seems unlikely that one will ever exist. Even if it did, I think this has little value.

Nowadays, I think this separation has no advantages for us and one significant cost: it makes installing `arcanist` more difficult for end-users.

This will need some more finesssing (Phabricator will need some changes for compatibility, and a lot of stuff that still says "libphutil" or "phutil" may eventually want to say "arcanist"), and some stuff (like xhpast) is probably straight-up broken right now and needs some tweaking, but I don't anticipate any major issues here. There was never anything particularly magical about libphutil as a separate standalone library.

Test Plan: Ran `arc`, it gets about as far as it did before.

Reviewers: amckinley

Reviewed By: amckinley

Maniphest Tasks: T13098

Differential Revision: https://secure.phabricator.com/D19688
2018-09-21 16:38:53 -07:00

71 lines
1.7 KiB
PHP
Executable file

#!/usr/bin/env php
<?php
require_once dirname(__FILE__).'/../__init_script__.php';
$args = new PhutilArgumentParser($argv);
$args->parseStandardArguments();
echo pht(
"PROGRESS BAR TEST SCRIPT\n\n".
"This script is a test script for `%s`. It will draw some progress bars, ".
"and generally allow you to test bar behaviors and changes.",
'PhutilConsoleProgressBar');
echo "\n\n";
echo pht(
"GENERAL NOTES\n\n".
" - When run as `%s`, no progress bars should be shown ".
"(stderr is not a tty).\n".
" - When run in a narrow terminal, the bar should resize automatically ".
"to fit the terminal.\n".
" - When run with `%s`, the bar should not be drawn.\n",
'php -f progress_bar.php 2>&1 | more',
'--trace');
echo "\n\n";
echo pht('STANDARD PROGRESS BAR')."\n";
$n = 80;
$bar = id(new PhutilConsoleProgressBar())
->setTotal($n);
for ($ii = 0; $ii < $n; $ii++) {
$bar->update(1);
usleep(10000);
}
$bar->done();
echo "\n".pht(
"INTERRUPTED PROGRESS BAR\n".
"This bar will be interrupted by an exception.\n".
"It should clean itself up.")."\n";
try {
run_interrupt_bar();
} catch (Exception $ex) {
echo pht('Caught exception!')."\n";
}
echo "\n".pht(
"RESIZING BARS\n".
"If you resize the window while a progress bars draws, it should more or ".
"less detect the change.");
$n = 1024;
$bar = id(new PhutilConsoleProgressBar())
->setTotal($n);
for ($ii = 0; $ii < $n; $ii++) {
$bar->update(1);
usleep(10000);
}
$bar->done();
function run_interrupt_bar() {
$bar = id(new PhutilConsoleProgressBar())
->setTotal(100);
for ($ii = 0; $ii < 100; $ii++) {
if ($ii === 20) {
throw new Exception(pht('Boo!'));
}
$bar->update(1);
usleep(10000);
}
}