1
0
Fork 0
mirror of https://we.phorge.it/source/arcanist.git synced 2024-10-24 17:48:50 +02:00
phorge-arcanist/src/lint
epriestley d57ea379c6 Fix "arc lint" exploding on new directories
Summary:
D1061 introduced a 'text file' check, but it fails under SVN for new
directories.

  - Revert D1061 (This reverts commit b2cd18252701be2093b52652fb3d1d94c5df571e.)
  - Make getChangedLines() return null to indicate that the operation doesn't
make sense. I think this was the intent of the code in the lint engine.
  - Fix a bug where running "arc lint" on a change in an SVN working copy from a
subdirectory would fail.
  - Fix a bug where warnings with no line information were incorrectly
discarded.

Test Plan:
  - Ran "arc lint" in an SVN working copy with a new directory (no failure).
  - Forced FilenameLinter to always raise a warning. Added a binary file and ran
"arc lint". The warning was reported for the new binary file, a new text file,
and a new directory.

Reviewers: jungejason, andrewjcg, nh, tuomaspelkonen, aran

Reviewed By: andrewjcg

CC: aran, andrewjcg, epriestley

Differential Revision: 1076
2011-11-03 14:28:04 -07:00
..
engine Fix "arc lint" exploding on new directories 2011-11-03 14:28:04 -07:00
linter support newer PyLint column numbers 2011-10-31 13:53:09 -07:00
message Fix an obscure dependency issue in Arcanist + libphutil 2011-08-03 12:17:49 -07:00
patcher Stop arc from destroying files under HPHPi. 2011-02-24 14:08:49 -08:00
renderer Improve lint rendering 2011-04-08 19:18:34 -07:00
result Some documentation. 2011-02-19 11:36:08 -08:00
severity Some documentation. 2011-02-19 11:36:08 -08:00