mirror of
https://we.phorge.it/source/arcanist.git
synced 2024-11-10 08:52:39 +01:00
No description
ba78000b38
Summary: Previously, arc patch would create a new commit under the existing current bookmark in mercurial. There have been two discussions about what the right behavior should be (D3334 and D3658). One side wants no commit at all, and one side wants a commit under a new bookmark. The current implementation is the worst of both worlds :( This change makes it create a new bookmark at the revision's base before commiting, same as the --bookmark flag used to do (which is now obsolete). That way the existing bookmark doesn't move (in mercurial >=1.8). This is the same behavior git has, which is convienent for groups migrating between the two. Also makes hg's getCanonicalRevision handle svn revisions just like git. This way arc patch will try to apply the patch to the appropriate revision in the history. Test Plan: Ran: arc patch - Verified it created a new bookmark and commited on top of the revision's base commit. arc patch --nobranch - Verified it put the new commit on top of the current bookmark without a new bookmark. arc patch --nocommit - Verified it left all the changes in the working copy. Also verified arc patch still works with git. Reviewers: epriestley Reviewed By: epriestley CC: sid0, bos, dschleimer, aran, Korvin Differential Revision: https://secure.phabricator.com/D5408 |
||
---|---|---|
bin | ||
externals | ||
resources | ||
scripts | ||
src | ||
.arcconfig | ||
.divinerconfig | ||
.editorconfig | ||
.gitignore | ||
LICENSE | ||
NOTICE | ||
README |
WHAT IS ARCANIST? Arcanist is the command-line tool for Phabricator. It allows you to interact with Phabricator installs to send code for review, download patches, transfer files, view status, make API calls, and various other things. You can find a complete user guide here: http://www.phabricator.com/docs/phabricator/article/Arcanist_User_Guide.html For more information about Phabricator, see: http://phabricator.org/ LICENSE Arcanist is released under the Apache 2.0 license except as otherwise noted.