1
0
Fork 0
mirror of https://we.phorge.it/source/arcanist.git synced 2025-01-07 21:31:01 +01:00
phorge-arcanist/src/lint
epriestley be67df6118 Extract and cover the logic for "trimming" a lint message
Summary:
Ref T9846. Sometimes, a lint message says to replace "the big bad wolf" with "the huge bad wolf": that is, the original and replacement text are the same at the beginning, or the end, or both.

To make this easier for humans to understand, we want to just show that "big" is being replaced with "huge", not that the entire phrase is being replaced.

This logic currently happens inline in console rendering. Pull it out and cover it so a future change can simplify console rendering.

Test Plan: Ran unit tests.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T9846

Differential Revision: https://secure.phabricator.com/D18509
2017-08-31 13:28:01 -07:00
..
__tests__ Extract and cover the logic for "trimming" a lint message 2017-08-31 13:28:01 -07:00
engine Check both UNIX- and Windows-style paths from linter output 2016-09-21 14:29:42 -07:00
linter Extract and cover the logic for "trimming" a lint message 2017-08-31 13:28:01 -07:00
renderer Extract and cover the logic for "trimming" a lint message 2017-08-31 13:28:01 -07:00
ArcanistLintMessage.php Extract and cover the logic for "trimming" a lint message 2017-08-31 13:28:01 -07:00
ArcanistLintPatcher.php Use phutil functions to copy/move files 2016-07-12 10:21:58 -07:00
ArcanistLintResult.php Extend from Phobject 2015-06-15 15:47:33 +10:00
ArcanistLintSeverity.php Extend from Phobject 2015-06-15 15:47:33 +10:00