mirror of
https://we.phorge.it/source/arcanist.git
synced 2024-11-27 01:02:41 +01:00
8e0e07664a
Summary: Ref T13098. Historically, Phabricator was split into three parts: - Phabricator, the server. - Arcanist, the client. - libphutil, libraries shared between the client and server. One imagined use case for this was that `libphutil` might become a general-purpose library that other projects would use. However, this didn't really happen, and it seems unlikely to at this point: Phabricator has become a relatively more sophisticated application platform; we didn't end up seeing or encouraging much custom development; what custom development there is basically embraces all of Phabricator since there are huge advantages to doing so; and a general "open source is awful" sort of factor here in the sense that open source users often don't have goals well aligned to our goals. Turning "arc" into a client platform and building package management solidify us in this direction of being a standalone platform, not a standalone utility library. Phabricator also depends on `arcanist/`. If it didn't, there would be a small advantage to saying "shared code + client for client, shared code + server for server", but there's no such distinction and it seems unlikely that one will ever exist. Even if it did, I think this has little value. Nowadays, I think this separation has no advantages for us and one significant cost: it makes installing `arcanist` more difficult for end-users. This will need some more finesssing (Phabricator will need some changes for compatibility, and a lot of stuff that still says "libphutil" or "phutil" may eventually want to say "arcanist"), and some stuff (like xhpast) is probably straight-up broken right now and needs some tweaking, but I don't anticipate any major issues here. There was never anything particularly magical about libphutil as a separate standalone library. Test Plan: Ran `arc`, it gets about as far as it did before. Reviewers: amckinley Reviewed By: amckinley Maniphest Tasks: T13098 Differential Revision: https://secure.phabricator.com/D19688
106 lines
2.1 KiB
C++
106 lines
2.1 KiB
C++
#pragma once
|
|
#include <cstdio>
|
|
#include <cstdlib>
|
|
#include <list>
|
|
#include <string>
|
|
|
|
namespace xhpast {
|
|
|
|
class Token;
|
|
typedef std::list<Token *> token_list_t;
|
|
|
|
class Token {
|
|
|
|
public:
|
|
unsigned int type;
|
|
std::string value;
|
|
unsigned int lineno;
|
|
unsigned int n;
|
|
|
|
Token(unsigned int type, char *value, unsigned int n) :
|
|
type(type),
|
|
value(value),
|
|
lineno(0),
|
|
n(n) {
|
|
}
|
|
};
|
|
|
|
class Node;
|
|
typedef std::list<Node *> node_list_t;
|
|
|
|
class Node {
|
|
public:
|
|
unsigned int type;
|
|
|
|
int l_tok;
|
|
int r_tok;
|
|
|
|
node_list_t children;
|
|
|
|
|
|
Node() : type(0), l_tok(-1), r_tok(-1) {};
|
|
|
|
Node(unsigned int type) : type(type), l_tok(-1), r_tok(-1) {};
|
|
|
|
Node(unsigned int type, int end_tok) :
|
|
type(type) {
|
|
this->l_tok = end_tok;
|
|
this->r_tok = end_tok;
|
|
}
|
|
|
|
Node(unsigned int type, int l_tok, int r_tok) :
|
|
type(type),
|
|
l_tok(l_tok),
|
|
r_tok(r_tok) {
|
|
|
|
}
|
|
|
|
Node *appendChild(Node *node) {
|
|
this->children.push_back(node);
|
|
return this->expandRange(node);
|
|
}
|
|
|
|
Node *appendChildren(Node *node) {
|
|
for (node_list_t::iterator ii = node->children.begin();
|
|
ii != node->children.end();
|
|
++ii) {
|
|
|
|
this->appendChild(*ii);
|
|
}
|
|
return this;
|
|
}
|
|
|
|
Node *firstChild() {
|
|
if (this->children.empty()) {
|
|
return NULL;
|
|
}
|
|
return *(this->children.begin());
|
|
}
|
|
|
|
Node *setType(unsigned int t) {
|
|
this->type = t;
|
|
return this;
|
|
}
|
|
|
|
Node *expandRange(Node *n) {
|
|
if (!n) {
|
|
fprintf(
|
|
stderr,
|
|
"Trying to expandRange() a null node to one of type %d\n",
|
|
this->type);
|
|
exit(1);
|
|
};
|
|
|
|
if (n->l_tok != -1 && (n->l_tok < this->l_tok || (this->l_tok == -1))) {
|
|
this->l_tok = n->l_tok;
|
|
}
|
|
|
|
if (n->r_tok != -1 && (n->r_tok > this->r_tok || (this->r_tok == -1))) {
|
|
this->r_tok = n->r_tok;
|
|
}
|
|
|
|
return this;
|
|
}
|
|
|
|
};
|
|
}
|