1
0
Fork 0
mirror of https://we.phorge.it/source/arcanist.git synced 2025-03-06 09:29:27 +01:00
phorge-arcanist/src/configuration
Miorel-Lucian Palii 7130004015 Don't instantiate abstract classes in ArcanistConfiguration::buildAllWorkflows
Summary:
I wanted to write a couple of workflows that shared some code in an abstract superclass, but ##arc## would fail trying to instantiate the abstract class.

As it turns out, we can modernize the ##buildAllWorkflows## function a bit, and it will only load concrete objects.

Test Plan:
1. Define an abstract subclass of ##ArcanistBaseWorkflow##.
2. ##arc liberate## the source directory that contains it.
3. Try any ##arc## operation without this diff, and see it fail.
4. Patch this diff and see that ##arc## operations work now.

Reviewers: epriestley, vrana

Reviewed By: epriestley

CC: aran, Korvin

Differential Revision: https://secure.phabricator.com/D6324
2013-06-28 18:24:30 -07:00
..
__tests__ Respect British spelling also in arguments 2013-03-01 16:53:26 -08:00
ArcanistConfiguration.php Don't instantiate abstract classes in ArcanistConfiguration::buildAllWorkflows 2013-06-28 18:24:30 -07:00
ArcanistSettings.php Disable lint cache by default 2013-04-23 11:26:28 -07:00