mirror of
https://we.phorge.it/source/arcanist.git
synced 2024-12-23 05:50:54 +01:00
No description
dccc8571d7
Summary: If you are trying to commit someone else's diff, arc commit gives warnings about path mismatch. This changes the path comparison to be based on the repo url rather than the local working directory. E.g. if both the author and committer are working in branches/release/2013_08_07 despite being checked out in ~/dev/2013_08_07 (system user being different, of course) it no longer warns that the WC path is different Original behavior: eric@Eric-MBP ~/dev/2013_07_31: arc commit --revision 21 You are not the author of 'D21: WeMerge Automatic Request'. Commit this revision anyway? [y/N] y Revision 'D21: WeMerge Automatic Request' was generated from '', but current working copy root is '/Users/eric/dev/2013_07_31/'. Commit this revision anyway? [y/N] y Committing 'D21: WeMerge Automatic Request'... Adding test Transmitting file data . Committed revision 52676. Closing revision D21 'WeMerge Automatic Request'... Exception ERR-CONDUIT-CORE: You can not mark a revision you don't own as closed. (Run with --trace for a full exception trace.) New behavior: eric@Eric-MBP ~/dev/2013_07_31: arc commit --revision 24 You are not the author of 'D24: WeMerge Automatic Request'. Commit this revision anyway? [y/N] y Committing 'D24: WeMerge Automatic Request'... Adding test Transmitting file data . Committed revision 52679. Closing revision D24 'WeMerge Automatic Request'... Exception ERR-CONDUIT-CORE: You can not mark a revision you don't own as closed. (Run with --trace for a full exception trace.) Test Plan: 'arc diff' changes with one user. 'arc patch Dxx' on a different working copy by a different user to review and test changes. accept review. 'arc commit --revision xx' as reviewer to land the patch. complaint goes away. Reviewers: epriestley, ghostwriter78 Reviewed By: epriestley CC: aran, epriestley, Korvin Differential Revision: https://secure.phabricator.com/D6665 |
||
|---|---|---|
| bin | ||
| externals | ||
| resources | ||
| scripts | ||
| src | ||
| .arcconfig | ||
| .divinerconfig | ||
| .editorconfig | ||
| .gitignore | ||
| LICENSE | ||
| NOTICE | ||
| README | ||
WHAT IS ARCANIST? Arcanist is the command-line tool for Phabricator. It allows you to interact with Phabricator installs to send code for review, download patches, transfer files, view status, make API calls, and various other things. You can find a complete user guide here: http://www.phabricator.com/docs/phabricator/article/Arcanist_User_Guide.html For more information about Phabricator, see: http://phabricator.org/ LICENSE Arcanist is released under the Apache 2.0 license except as otherwise noted.