mirror of
https://we.phorge.it/source/arcanist.git
synced 2025-01-24 13:38:18 +01:00
92713cf922
Summary: Ref T5655. This class was deprecated in D11673. Test Plan: Wait a few months. Reviewers: #blessed_reviewers, epriestley Reviewed By: #blessed_reviewers, epriestley Subscribers: Korvin, epriestley Maniphest Tasks: T5655 Differential Revision: https://secure.phabricator.com/D11740
55 lines
1.7 KiB
PHP
55 lines
1.7 KiB
PHP
<?php
|
|
|
|
/**
|
|
* Basic lint engine which just applies several linters based on the file types.
|
|
*/
|
|
final class ArcanistComprehensiveLintEngine extends ArcanistLintEngine {
|
|
|
|
public function buildLinters() {
|
|
$linters = array();
|
|
|
|
$paths = $this->getPaths();
|
|
|
|
foreach ($paths as $key => $path) {
|
|
if (preg_match('@^externals/@', $path)) {
|
|
// Third-party stuff lives in /externals/; don't run lint engines
|
|
// against it.
|
|
unset($paths[$key]);
|
|
}
|
|
}
|
|
|
|
$text_paths = preg_grep('/\.(php|css|hpp|cpp|l|y|py|pl)$/', $paths);
|
|
$linters[] = id(new ArcanistGeneratedLinter())->setPaths($text_paths);
|
|
$linters[] = id(new ArcanistNoLintLinter())->setPaths($text_paths);
|
|
$linters[] = id(new ArcanistTextLinter())->setPaths($text_paths);
|
|
|
|
$linters[] = id(new ArcanistFilenameLinter())->setPaths($paths);
|
|
|
|
$linters[] = id(new ArcanistXHPASTLinter())
|
|
->setPaths(preg_grep('/\.php$/', $paths));
|
|
|
|
$py_paths = preg_grep('/\.py$/', $paths);
|
|
$linters[] = id(new ArcanistPyFlakesLinter())->setPaths($py_paths);
|
|
$linters[] = id(new ArcanistPEP8Linter())
|
|
->setFlags($this->getPEP8WithTextOptions())
|
|
->setPaths($py_paths);
|
|
|
|
$linters[] = id(new ArcanistRubyLinter())
|
|
->setPaths(preg_grep('/\.rb$/', $paths));
|
|
|
|
$linters[] = id(new ArcanistJSHintLinter())
|
|
->setPaths(preg_grep('/\.js$/', $paths));
|
|
|
|
return $linters;
|
|
}
|
|
|
|
protected function getPEP8WithTextOptions() {
|
|
// E101 is subset of TXT2 (Tab Literal).
|
|
// E501 is same as TXT3 (Line Too Long).
|
|
// W291 is same as TXT6 (Trailing Whitespace).
|
|
// W292 is same as TXT4 (File Does Not End in Newline).
|
|
// W293 is same as TXT6 (Trailing Whitespace).
|
|
return array('--ignore=E101,E501,W291,W292,W293');
|
|
}
|
|
|
|
}
|