mirror of
https://we.phorge.it/source/arcanist.git
synced 2025-01-07 21:31:01 +01:00
dfde57ff81
Summary: Fixes T9222. Two issues here: - First, we currently continue on error. Throw instead. I just swapped us from "phutil_passthru()" to "execx()" since I don't think printing out the "pulling from remote..." status messages is very important, and this makes it easier to raise a useful exception. - Second, if you have a dirty working copy we currently may try to do some sort of silly stuff which won't work, like prompt you to amend changes. Instead, do a slightly lower-level check and just bail. Test Plan: - Ran `arc upgrade` with a dirty working copy and got a tailored, useful error. - Ran `arc upgrade` with an artificially bad `git pull` command, got a failure with a specific error message. Reviewers: chad Reviewed By: chad Maniphest Tasks: T9222 Differential Revision: https://secure.phabricator.com/D14317 |
||
|---|---|---|
| .. | ||
| exception | ||
| ArcanistAliasWorkflow.php | ||
| ArcanistAmendWorkflow.php | ||
| ArcanistAnoidWorkflow.php | ||
| ArcanistBackoutWorkflow.php | ||
| ArcanistBookmarkWorkflow.php | ||
| ArcanistBranchWorkflow.php | ||
| ArcanistBrowseWorkflow.php | ||
| ArcanistCallConduitWorkflow.php | ||
| ArcanistCloseRevisionWorkflow.php | ||
| ArcanistCloseWorkflow.php | ||
| ArcanistCommitWorkflow.php | ||
| ArcanistCoverWorkflow.php | ||
| ArcanistDiffWorkflow.php | ||
| ArcanistDownloadWorkflow.php | ||
| ArcanistExportWorkflow.php | ||
| ArcanistFeatureWorkflow.php | ||
| ArcanistFlagWorkflow.php | ||
| ArcanistGetConfigWorkflow.php | ||
| ArcanistHelpWorkflow.php | ||
| ArcanistInstallCertificateWorkflow.php | ||
| ArcanistLandWorkflow.php | ||
| ArcanistLiberateWorkflow.php | ||
| ArcanistLintersWorkflow.php | ||
| ArcanistLintWorkflow.php | ||
| ArcanistListWorkflow.php | ||
| ArcanistPasteWorkflow.php | ||
| ArcanistPatchWorkflow.php | ||
| ArcanistPhrequentWorkflow.php | ||
| ArcanistRevertWorkflow.php | ||
| ArcanistSetConfigWorkflow.php | ||
| ArcanistShellCompleteWorkflow.php | ||
| ArcanistStartWorkflow.php | ||
| ArcanistStopWorkflow.php | ||
| ArcanistTasksWorkflow.php | ||
| ArcanistTimeWorkflow.php | ||
| ArcanistTodoWorkflow.php | ||
| ArcanistUnitWorkflow.php | ||
| ArcanistUpgradeWorkflow.php | ||
| ArcanistUploadWorkflow.php | ||
| ArcanistVersionWorkflow.php | ||
| ArcanistWhichWorkflow.php | ||
| ArcanistWorkflow.php | ||