mirror of
https://we.phorge.it/source/arcanist.git
synced 2024-10-24 17:48:50 +02:00
66d204be81
Summary: This commit doesn't change license of any file. It just makes the license implicit (inherited from LICENSE file in the root directory). We are removing the headers for these reasons: - It wastes space in editors, less code is visible in editor upon opening a file. - It brings noise to diff of the first change of any file every year. - It confuses Git file copy detection when creating small files. - We don't have an explicit license header in other files (JS, CSS, images, documentation). - Using license header in every file is not obligatory: http://www.apache.org/dev/apply-license.html#new. This change is approved by Alma Chao (Lead Open Source and IP Counsel at Facebook). Test Plan: Verified that the license survived only in unit tests and LICENSE file. Reviewers: epriestley, btrahan, edward Reviewed By: epriestley CC: aran, Korvin, davidrecordon Maniphest Tasks: T2035 Differential Revision: https://secure.phabricator.com/D3881
86 lines
2.1 KiB
PHP
86 lines
2.1 KiB
PHP
<?php
|
|
|
|
/**
|
|
* Uses "Ruby" to detect various errors in Ruby code.
|
|
*
|
|
* @group linter
|
|
*/
|
|
final class ArcanistRubyLinter extends ArcanistLinter {
|
|
|
|
public function willLintPaths(array $paths) {
|
|
return;
|
|
}
|
|
|
|
public function getLinterName() {
|
|
return 'Ruby';
|
|
}
|
|
|
|
public function getLintSeverityMap() {
|
|
return array();
|
|
}
|
|
|
|
public function getLintNameMap() {
|
|
return array();
|
|
}
|
|
|
|
private function getRubyPath() {
|
|
$ruby_bin = "ruby";
|
|
|
|
// Use the Ruby prefix specified in the config file
|
|
$working_copy = $this->getEngine()->getWorkingCopy();
|
|
$prefix = $working_copy->getConfig('lint.ruby.prefix');
|
|
if ($prefix !== null) {
|
|
$ruby_bin = $prefix . $ruby_bin;
|
|
}
|
|
|
|
if (!Filesystem::pathExists($ruby_bin)) {
|
|
|
|
list($err) = exec_manual('which %s', $ruby_bin);
|
|
if ($err) {
|
|
throw new ArcanistUsageException(
|
|
"Ruby does not appear to be installed on this system. Install it or ".
|
|
"add 'lint.ruby.prefix' in your .arcconfig to point to ".
|
|
"the directory where it resides.");
|
|
}
|
|
}
|
|
|
|
return $ruby_bin;
|
|
}
|
|
|
|
private function getMessageCodeSeverity($code) {
|
|
return ArcanistLintSeverity::SEVERITY_ERROR;
|
|
}
|
|
|
|
public function lintPath($path) {
|
|
$rubyp = $this->getRubyPath();
|
|
$f = new ExecFuture("%s -wc", $rubyp);
|
|
$f->write($this->getData($path));
|
|
list($err, $stdout, $stderr) = $f->resolve();
|
|
if ($err === 0 ) {
|
|
return;
|
|
}
|
|
|
|
$lines = explode("\n", $stderr);
|
|
$messages = array();
|
|
foreach ($lines as $line) {
|
|
$matches = null;
|
|
if (!preg_match("/(.*?):(\d+): (.*?)$/", $line, $matches)) {
|
|
continue;
|
|
}
|
|
foreach ($matches as $key => $match) {
|
|
$matches[$key] = trim($match);
|
|
}
|
|
|
|
$code = head(explode(',', $matches[3]));
|
|
|
|
$message = new ArcanistLintMessage();
|
|
$message->setPath($path);
|
|
$message->setLine($matches[2]);
|
|
$message->setName($this->getLinterName() . " " . $code);
|
|
$message->setDescription($matches[3]);
|
|
$message->setSeverity($this->getMessageCodeSeverity($code));
|
|
$this->addLintMessage($message);
|
|
}
|
|
}
|
|
|
|
}
|