mirror of
https://we.phorge.it/source/arcanist.git
synced 2024-11-22 06:42:41 +01:00
No description
fed73b75cf
Summary: With the current order of the include_path (checking in the parent dir of arcanist last), it is possible to load the wrong libphutil which can have bad side effects. Instead, the first place we check in include_path should be the parent dir of arcanist. (The issue I ran into is that I had a checkout of libphutil in my homedir, and I was running arc from my homedir with --load-phutil-library to load the libraries, and since ./ is the default value for include_path, we were loading libphutil from my homedir instead of from alongside the copy of arc that I was running. The libphutil alongside that copy of arc worked, but my checkout of libphutil had D2545 in it, so it was broken.) Test Plan: ran arc (not in my homedir) with a broken libphutil in my homedir in my homedir and it worked (before this change it didn't) Reviewers: jungejason, vrana, epriestley Reviewed By: vrana CC: aran, Koolvin Differential Revision: https://secure.phabricator.com/D2576 |
||
|---|---|---|
| bin | ||
| externals | ||
| resources | ||
| scripts | ||
| src | ||
| .arcconfig | ||
| .divinerconfig | ||
| .gitignore | ||
| LICENSE | ||
| README | ||
WHAT IS ARCANIST? Arcanist is the command-line tool for Phabricator. It allows you to interact with Phabricator installs to send code for review, download patches, transfer files, view status, make API calls, and various other things. You can find a complete user guide here: http://www.phabricator.com/docs/phabricator/article/Arcanist_User_Guide.html For more information about Phabricator, see: http://phabricator.org/