2016-02-10 14:59:46 +01:00
|
|
|
/**
|
|
|
|
* @provides javelin-workboard-column
|
|
|
|
* @requires javelin-install
|
|
|
|
* javelin-workboard-card
|
Add priority group headers to workboard columns (display only)
Summary:
Ref T10333. When workboards are ordered (for example, by priority), add headers to the various groups. Major goals are:
- Allow users to drag-and-drop to set values that no cards currently have: for example, you can change a card priority to "normal" by dragging it under the "normal" header, even if no other cards in the column are currently "Normal".
- Make future orderings more useful, particularly "order by assignee". We don't really have room to put the username on every card and it would create a fair amount of clutter, but we can put usernames in these headers and then reference them with just the profile picture. This also allows you to assign to users who are not currently assigned anything in a given column.
- Make the drag-and-drop behavior more obvious by showing what it will do more clearly (see T8135).
- Make things a little easier to scan in general: because space on cards is limited, some information isn't conveyed very clearly (for example, priority information is currently conveyed //only// through color, which can be hard to pick out visually and is probably not functional for users who need vision accommodations).
- Maybe do "swimlanes": this is pretty much a "swimlanes" UI if we add whitespace at the bottom of each group so that the headers line up across all the columns (e.g., "Normal" is at the same y-axis position in every column as you scroll down the page). Not sold on this being useful, but it's just a UI adjustment if we do want to try it.
NOTE: This only makes these headers work for display.
They aren't yet recognized as targets by the drag list UI, so you can't drag cards into an empty group. I'll tackle that in a followup.
Test Plan: {F6257686}
Reviewers: amckinley
Reviewed By: amckinley
Maniphest Tasks: T10333
Differential Revision: https://secure.phabricator.com/D20247
2019-03-05 15:00:12 +01:00
|
|
|
* javelin-workboard-header
|
2016-02-10 14:59:46 +01:00
|
|
|
* @javelin
|
|
|
|
*/
|
|
|
|
|
|
|
|
JX.install('WorkboardColumn', {
|
|
|
|
|
|
|
|
construct: function(board, phid, root) {
|
|
|
|
this._board = board;
|
|
|
|
this._phid = phid;
|
|
|
|
this._root = root;
|
|
|
|
|
2016-02-10 22:53:36 +01:00
|
|
|
this._panel = JX.DOM.findAbove(root, 'div', 'workpanel');
|
|
|
|
this._pointsNode = JX.DOM.find(this._panel, 'span', 'column-points');
|
|
|
|
|
|
|
|
this._pointsContentNode = JX.DOM.find(
|
|
|
|
this._panel,
|
|
|
|
'span',
|
|
|
|
'column-points-content');
|
|
|
|
|
2016-02-10 14:59:46 +01:00
|
|
|
this._cards = {};
|
Add priority group headers to workboard columns (display only)
Summary:
Ref T10333. When workboards are ordered (for example, by priority), add headers to the various groups. Major goals are:
- Allow users to drag-and-drop to set values that no cards currently have: for example, you can change a card priority to "normal" by dragging it under the "normal" header, even if no other cards in the column are currently "Normal".
- Make future orderings more useful, particularly "order by assignee". We don't really have room to put the username on every card and it would create a fair amount of clutter, but we can put usernames in these headers and then reference them with just the profile picture. This also allows you to assign to users who are not currently assigned anything in a given column.
- Make the drag-and-drop behavior more obvious by showing what it will do more clearly (see T8135).
- Make things a little easier to scan in general: because space on cards is limited, some information isn't conveyed very clearly (for example, priority information is currently conveyed //only// through color, which can be hard to pick out visually and is probably not functional for users who need vision accommodations).
- Maybe do "swimlanes": this is pretty much a "swimlanes" UI if we add whitespace at the bottom of each group so that the headers line up across all the columns (e.g., "Normal" is at the same y-axis position in every column as you scroll down the page). Not sold on this being useful, but it's just a UI adjustment if we do want to try it.
NOTE: This only makes these headers work for display.
They aren't yet recognized as targets by the drag list UI, so you can't drag cards into an empty group. I'll tackle that in a followup.
Test Plan: {F6257686}
Reviewers: amckinley
Reviewed By: amckinley
Maniphest Tasks: T10333
Differential Revision: https://secure.phabricator.com/D20247
2019-03-05 15:00:12 +01:00
|
|
|
this._headers = {};
|
|
|
|
this._objects = [];
|
2016-02-10 14:59:46 +01:00
|
|
|
this._naturalOrder = [];
|
|
|
|
},
|
|
|
|
|
|
|
|
members: {
|
|
|
|
_phid: null,
|
|
|
|
_root: null,
|
|
|
|
_board: null,
|
|
|
|
_cards: null,
|
Add priority group headers to workboard columns (display only)
Summary:
Ref T10333. When workboards are ordered (for example, by priority), add headers to the various groups. Major goals are:
- Allow users to drag-and-drop to set values that no cards currently have: for example, you can change a card priority to "normal" by dragging it under the "normal" header, even if no other cards in the column are currently "Normal".
- Make future orderings more useful, particularly "order by assignee". We don't really have room to put the username on every card and it would create a fair amount of clutter, but we can put usernames in these headers and then reference them with just the profile picture. This also allows you to assign to users who are not currently assigned anything in a given column.
- Make the drag-and-drop behavior more obvious by showing what it will do more clearly (see T8135).
- Make things a little easier to scan in general: because space on cards is limited, some information isn't conveyed very clearly (for example, priority information is currently conveyed //only// through color, which can be hard to pick out visually and is probably not functional for users who need vision accommodations).
- Maybe do "swimlanes": this is pretty much a "swimlanes" UI if we add whitespace at the bottom of each group so that the headers line up across all the columns (e.g., "Normal" is at the same y-axis position in every column as you scroll down the page). Not sold on this being useful, but it's just a UI adjustment if we do want to try it.
NOTE: This only makes these headers work for display.
They aren't yet recognized as targets by the drag list UI, so you can't drag cards into an empty group. I'll tackle that in a followup.
Test Plan: {F6257686}
Reviewers: amckinley
Reviewed By: amckinley
Maniphest Tasks: T10333
Differential Revision: https://secure.phabricator.com/D20247
2019-03-05 15:00:12 +01:00
|
|
|
_headers: null,
|
2016-02-10 14:59:46 +01:00
|
|
|
_naturalOrder: null,
|
2016-02-10 22:53:36 +01:00
|
|
|
_panel: null,
|
|
|
|
_pointsNode: null,
|
|
|
|
_pointsContentNode: null,
|
|
|
|
_dirty: true,
|
Add priority group headers to workboard columns (display only)
Summary:
Ref T10333. When workboards are ordered (for example, by priority), add headers to the various groups. Major goals are:
- Allow users to drag-and-drop to set values that no cards currently have: for example, you can change a card priority to "normal" by dragging it under the "normal" header, even if no other cards in the column are currently "Normal".
- Make future orderings more useful, particularly "order by assignee". We don't really have room to put the username on every card and it would create a fair amount of clutter, but we can put usernames in these headers and then reference them with just the profile picture. This also allows you to assign to users who are not currently assigned anything in a given column.
- Make the drag-and-drop behavior more obvious by showing what it will do more clearly (see T8135).
- Make things a little easier to scan in general: because space on cards is limited, some information isn't conveyed very clearly (for example, priority information is currently conveyed //only// through color, which can be hard to pick out visually and is probably not functional for users who need vision accommodations).
- Maybe do "swimlanes": this is pretty much a "swimlanes" UI if we add whitespace at the bottom of each group so that the headers line up across all the columns (e.g., "Normal" is at the same y-axis position in every column as you scroll down the page). Not sold on this being useful, but it's just a UI adjustment if we do want to try it.
NOTE: This only makes these headers work for display.
They aren't yet recognized as targets by the drag list UI, so you can't drag cards into an empty group. I'll tackle that in a followup.
Test Plan: {F6257686}
Reviewers: amckinley
Reviewed By: amckinley
Maniphest Tasks: T10333
Differential Revision: https://secure.phabricator.com/D20247
2019-03-05 15:00:12 +01:00
|
|
|
_objects: null,
|
2016-02-10 14:59:46 +01:00
|
|
|
|
|
|
|
getPHID: function() {
|
|
|
|
return this._phid;
|
|
|
|
},
|
|
|
|
|
|
|
|
getRoot: function() {
|
|
|
|
return this._root;
|
|
|
|
},
|
|
|
|
|
|
|
|
getCards: function() {
|
|
|
|
return this._cards;
|
|
|
|
},
|
|
|
|
|
Make drag-and-drop on workboards interact with priority column headers
Summary:
Ref T10333. Ref T8135. Depends on D20247. Allow users to drag-and-drop cards on a priority-sorted workboard under headers, even if the header has no other cards.
As of D20247, headers show up but they aren't really interactive. Now, you can drag cards directly underneath a header (instead of only between other cards). For example, if a column has only one "Wishlist" task, you may drag it under the "High", "Normal", or "Low" priority headers to select a specific priority.
(Some of this code still feels a little rough, but I think it will generalize once other types of sorting are available.)
Test Plan: Dragged cards within and between priority groups, saw appropriate priority edits applied in every case I could come up with.
Reviewers: amckinley
Reviewed By: amckinley
Maniphest Tasks: T10333, T8135
Differential Revision: https://secure.phabricator.com/D20248
2019-03-05 16:38:35 +01:00
|
|
|
_getObjects: function() {
|
|
|
|
return this._objects;
|
|
|
|
},
|
|
|
|
|
2016-02-10 14:59:46 +01:00
|
|
|
getCard: function(phid) {
|
|
|
|
return this._cards[phid];
|
|
|
|
},
|
|
|
|
|
|
|
|
getBoard: function() {
|
|
|
|
return this._board;
|
|
|
|
},
|
|
|
|
|
|
|
|
setNaturalOrder: function(order) {
|
|
|
|
this._naturalOrder = order;
|
|
|
|
return this;
|
|
|
|
},
|
|
|
|
|
2016-02-10 22:53:36 +01:00
|
|
|
getPointsNode: function() {
|
|
|
|
return this._pointsNode;
|
|
|
|
},
|
|
|
|
|
|
|
|
getPointsContentNode: function() {
|
|
|
|
return this._pointsContentNode;
|
|
|
|
},
|
|
|
|
|
|
|
|
getWorkpanelNode: function() {
|
|
|
|
return this._panel;
|
|
|
|
},
|
|
|
|
|
2016-02-10 14:59:46 +01:00
|
|
|
newCard: function(phid) {
|
|
|
|
var card = new JX.WorkboardCard(this, phid);
|
|
|
|
|
|
|
|
this._cards[phid] = card;
|
|
|
|
this._naturalOrder.push(phid);
|
|
|
|
|
|
|
|
return card;
|
|
|
|
},
|
|
|
|
|
|
|
|
removeCard: function(phid) {
|
|
|
|
var card = this._cards[phid];
|
|
|
|
delete this._cards[phid];
|
|
|
|
|
|
|
|
for (var ii = 0; ii < this._naturalOrder.length; ii++) {
|
|
|
|
if (this._naturalOrder[ii] == phid) {
|
|
|
|
this._naturalOrder.splice(ii, 1);
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
return card;
|
|
|
|
},
|
|
|
|
|
|
|
|
addCard: function(card, after) {
|
|
|
|
var phid = card.getPHID();
|
|
|
|
|
|
|
|
card.setColumn(this);
|
|
|
|
this._cards[phid] = card;
|
|
|
|
|
|
|
|
var index = 0;
|
|
|
|
|
|
|
|
if (after) {
|
|
|
|
for (var ii = 0; ii < this._naturalOrder.length; ii++) {
|
|
|
|
if (this._naturalOrder[ii] == after) {
|
|
|
|
index = ii + 1;
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
if (index > this._naturalOrder.length) {
|
|
|
|
this._naturalOrder.push(phid);
|
|
|
|
} else {
|
|
|
|
this._naturalOrder.splice(index, 0, phid);
|
|
|
|
}
|
|
|
|
|
|
|
|
return this;
|
|
|
|
},
|
|
|
|
|
Make drag-and-drop on workboards interact with priority column headers
Summary:
Ref T10333. Ref T8135. Depends on D20247. Allow users to drag-and-drop cards on a priority-sorted workboard under headers, even if the header has no other cards.
As of D20247, headers show up but they aren't really interactive. Now, you can drag cards directly underneath a header (instead of only between other cards). For example, if a column has only one "Wishlist" task, you may drag it under the "High", "Normal", or "Low" priority headers to select a specific priority.
(Some of this code still feels a little rough, but I think it will generalize once other types of sorting are available.)
Test Plan: Dragged cards within and between priority groups, saw appropriate priority edits applied in every case I could come up with.
Reviewers: amckinley
Reviewed By: amckinley
Maniphest Tasks: T10333, T8135
Differential Revision: https://secure.phabricator.com/D20248
2019-03-05 16:38:35 +01:00
|
|
|
getDropTargetNodes: function() {
|
|
|
|
var objects = this._getObjects();
|
2016-02-10 14:59:46 +01:00
|
|
|
|
|
|
|
var nodes = [];
|
Make drag-and-drop on workboards interact with priority column headers
Summary:
Ref T10333. Ref T8135. Depends on D20247. Allow users to drag-and-drop cards on a priority-sorted workboard under headers, even if the header has no other cards.
As of D20247, headers show up but they aren't really interactive. Now, you can drag cards directly underneath a header (instead of only between other cards). For example, if a column has only one "Wishlist" task, you may drag it under the "High", "Normal", or "Low" priority headers to select a specific priority.
(Some of this code still feels a little rough, but I think it will generalize once other types of sorting are available.)
Test Plan: Dragged cards within and between priority groups, saw appropriate priority edits applied in every case I could come up with.
Reviewers: amckinley
Reviewed By: amckinley
Maniphest Tasks: T10333, T8135
Differential Revision: https://secure.phabricator.com/D20248
2019-03-05 16:38:35 +01:00
|
|
|
for (var ii = 0; ii < objects.length; ii++) {
|
|
|
|
var object = objects[ii];
|
|
|
|
nodes.push(object.getNode());
|
2016-02-10 14:59:46 +01:00
|
|
|
}
|
|
|
|
|
|
|
|
return nodes;
|
|
|
|
},
|
|
|
|
|
|
|
|
getCardPHIDs: function() {
|
|
|
|
return JX.keys(this.getCards());
|
|
|
|
},
|
|
|
|
|
2016-02-10 22:53:36 +01:00
|
|
|
getPointLimit: function() {
|
|
|
|
return JX.Stratcom.getData(this.getRoot()).pointLimit;
|
|
|
|
},
|
|
|
|
|
|
|
|
markForRedraw: function() {
|
|
|
|
this._dirty = true;
|
|
|
|
},
|
|
|
|
|
|
|
|
isMarkedForRedraw: function() {
|
|
|
|
return this._dirty;
|
|
|
|
},
|
|
|
|
|
Add priority group headers to workboard columns (display only)
Summary:
Ref T10333. When workboards are ordered (for example, by priority), add headers to the various groups. Major goals are:
- Allow users to drag-and-drop to set values that no cards currently have: for example, you can change a card priority to "normal" by dragging it under the "normal" header, even if no other cards in the column are currently "Normal".
- Make future orderings more useful, particularly "order by assignee". We don't really have room to put the username on every card and it would create a fair amount of clutter, but we can put usernames in these headers and then reference them with just the profile picture. This also allows you to assign to users who are not currently assigned anything in a given column.
- Make the drag-and-drop behavior more obvious by showing what it will do more clearly (see T8135).
- Make things a little easier to scan in general: because space on cards is limited, some information isn't conveyed very clearly (for example, priority information is currently conveyed //only// through color, which can be hard to pick out visually and is probably not functional for users who need vision accommodations).
- Maybe do "swimlanes": this is pretty much a "swimlanes" UI if we add whitespace at the bottom of each group so that the headers line up across all the columns (e.g., "Normal" is at the same y-axis position in every column as you scroll down the page). Not sold on this being useful, but it's just a UI adjustment if we do want to try it.
NOTE: This only makes these headers work for display.
They aren't yet recognized as targets by the drag list UI, so you can't drag cards into an empty group. I'll tackle that in a followup.
Test Plan: {F6257686}
Reviewers: amckinley
Reviewed By: amckinley
Maniphest Tasks: T10333
Differential Revision: https://secure.phabricator.com/D20247
2019-03-05 15:00:12 +01:00
|
|
|
getHeader: function(key) {
|
|
|
|
if (!this._headers[key]) {
|
|
|
|
this._headers[key] = new JX.WorkboardHeader(this, key);
|
|
|
|
}
|
|
|
|
return this._headers[key];
|
|
|
|
},
|
|
|
|
|
Make drag-and-drop on workboards interact with priority column headers
Summary:
Ref T10333. Ref T8135. Depends on D20247. Allow users to drag-and-drop cards on a priority-sorted workboard under headers, even if the header has no other cards.
As of D20247, headers show up but they aren't really interactive. Now, you can drag cards directly underneath a header (instead of only between other cards). For example, if a column has only one "Wishlist" task, you may drag it under the "High", "Normal", or "Low" priority headers to select a specific priority.
(Some of this code still feels a little rough, but I think it will generalize once other types of sorting are available.)
Test Plan: Dragged cards within and between priority groups, saw appropriate priority edits applied in every case I could come up with.
Reviewers: amckinley
Reviewed By: amckinley
Maniphest Tasks: T10333, T8135
Differential Revision: https://secure.phabricator.com/D20248
2019-03-05 16:38:35 +01:00
|
|
|
handleDragGhost: function(default_handler, ghost, node) {
|
|
|
|
// If the column has headers, don't let the user drag a card above
|
|
|
|
// the topmost header: for example, you can't change a task to have
|
|
|
|
// a priority higher than the highest possible priority.
|
|
|
|
|
|
|
|
if (this._hasColumnHeaders()) {
|
|
|
|
if (!node) {
|
|
|
|
return false;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
return default_handler(ghost, node);
|
|
|
|
},
|
|
|
|
|
|
|
|
_hasColumnHeaders: function() {
|
|
|
|
var board = this.getBoard();
|
|
|
|
var order = board.getOrder();
|
|
|
|
|
|
|
|
switch (order) {
|
|
|
|
case 'natural':
|
|
|
|
return false;
|
|
|
|
}
|
|
|
|
|
|
|
|
return true;
|
|
|
|
},
|
|
|
|
|
Add priority group headers to workboard columns (display only)
Summary:
Ref T10333. When workboards are ordered (for example, by priority), add headers to the various groups. Major goals are:
- Allow users to drag-and-drop to set values that no cards currently have: for example, you can change a card priority to "normal" by dragging it under the "normal" header, even if no other cards in the column are currently "Normal".
- Make future orderings more useful, particularly "order by assignee". We don't really have room to put the username on every card and it would create a fair amount of clutter, but we can put usernames in these headers and then reference them with just the profile picture. This also allows you to assign to users who are not currently assigned anything in a given column.
- Make the drag-and-drop behavior more obvious by showing what it will do more clearly (see T8135).
- Make things a little easier to scan in general: because space on cards is limited, some information isn't conveyed very clearly (for example, priority information is currently conveyed //only// through color, which can be hard to pick out visually and is probably not functional for users who need vision accommodations).
- Maybe do "swimlanes": this is pretty much a "swimlanes" UI if we add whitespace at the bottom of each group so that the headers line up across all the columns (e.g., "Normal" is at the same y-axis position in every column as you scroll down the page). Not sold on this being useful, but it's just a UI adjustment if we do want to try it.
NOTE: This only makes these headers work for display.
They aren't yet recognized as targets by the drag list UI, so you can't drag cards into an empty group. I'll tackle that in a followup.
Test Plan: {F6257686}
Reviewers: amckinley
Reviewed By: amckinley
Maniphest Tasks: T10333
Differential Revision: https://secure.phabricator.com/D20247
2019-03-05 15:00:12 +01:00
|
|
|
_getCardHeaderKey: function(card, order) {
|
|
|
|
switch (order) {
|
|
|
|
case 'priority':
|
|
|
|
return 'priority(' + card.getPriority() + ')';
|
|
|
|
default:
|
|
|
|
return null;
|
|
|
|
}
|
|
|
|
},
|
|
|
|
|
2016-02-10 14:59:46 +01:00
|
|
|
redraw: function() {
|
2016-02-10 22:53:36 +01:00
|
|
|
var board = this.getBoard();
|
|
|
|
var order = board.getOrder();
|
2016-02-10 14:59:46 +01:00
|
|
|
|
|
|
|
var list;
|
|
|
|
if (order == 'natural') {
|
|
|
|
list = this._getCardsSortedNaturally();
|
|
|
|
} else {
|
|
|
|
list = this._getCardsSortedByKey(order);
|
|
|
|
}
|
|
|
|
|
Add priority group headers to workboard columns (display only)
Summary:
Ref T10333. When workboards are ordered (for example, by priority), add headers to the various groups. Major goals are:
- Allow users to drag-and-drop to set values that no cards currently have: for example, you can change a card priority to "normal" by dragging it under the "normal" header, even if no other cards in the column are currently "Normal".
- Make future orderings more useful, particularly "order by assignee". We don't really have room to put the username on every card and it would create a fair amount of clutter, but we can put usernames in these headers and then reference them with just the profile picture. This also allows you to assign to users who are not currently assigned anything in a given column.
- Make the drag-and-drop behavior more obvious by showing what it will do more clearly (see T8135).
- Make things a little easier to scan in general: because space on cards is limited, some information isn't conveyed very clearly (for example, priority information is currently conveyed //only// through color, which can be hard to pick out visually and is probably not functional for users who need vision accommodations).
- Maybe do "swimlanes": this is pretty much a "swimlanes" UI if we add whitespace at the bottom of each group so that the headers line up across all the columns (e.g., "Normal" is at the same y-axis position in every column as you scroll down the page). Not sold on this being useful, but it's just a UI adjustment if we do want to try it.
NOTE: This only makes these headers work for display.
They aren't yet recognized as targets by the drag list UI, so you can't drag cards into an empty group. I'll tackle that in a followup.
Test Plan: {F6257686}
Reviewers: amckinley
Reviewed By: amckinley
Maniphest Tasks: T10333
Differential Revision: https://secure.phabricator.com/D20247
2019-03-05 15:00:12 +01:00
|
|
|
var ii;
|
|
|
|
var objects = [];
|
|
|
|
|
Make drag-and-drop on workboards interact with priority column headers
Summary:
Ref T10333. Ref T8135. Depends on D20247. Allow users to drag-and-drop cards on a priority-sorted workboard under headers, even if the header has no other cards.
As of D20247, headers show up but they aren't really interactive. Now, you can drag cards directly underneath a header (instead of only between other cards). For example, if a column has only one "Wishlist" task, you may drag it under the "High", "Normal", or "Low" priority headers to select a specific priority.
(Some of this code still feels a little rough, but I think it will generalize once other types of sorting are available.)
Test Plan: Dragged cards within and between priority groups, saw appropriate priority edits applied in every case I could come up with.
Reviewers: amckinley
Reviewed By: amckinley
Maniphest Tasks: T10333, T8135
Differential Revision: https://secure.phabricator.com/D20248
2019-03-05 16:38:35 +01:00
|
|
|
var has_headers = this._hasColumnHeaders();
|
Add priority group headers to workboard columns (display only)
Summary:
Ref T10333. When workboards are ordered (for example, by priority), add headers to the various groups. Major goals are:
- Allow users to drag-and-drop to set values that no cards currently have: for example, you can change a card priority to "normal" by dragging it under the "normal" header, even if no other cards in the column are currently "Normal".
- Make future orderings more useful, particularly "order by assignee". We don't really have room to put the username on every card and it would create a fair amount of clutter, but we can put usernames in these headers and then reference them with just the profile picture. This also allows you to assign to users who are not currently assigned anything in a given column.
- Make the drag-and-drop behavior more obvious by showing what it will do more clearly (see T8135).
- Make things a little easier to scan in general: because space on cards is limited, some information isn't conveyed very clearly (for example, priority information is currently conveyed //only// through color, which can be hard to pick out visually and is probably not functional for users who need vision accommodations).
- Maybe do "swimlanes": this is pretty much a "swimlanes" UI if we add whitespace at the bottom of each group so that the headers line up across all the columns (e.g., "Normal" is at the same y-axis position in every column as you scroll down the page). Not sold on this being useful, but it's just a UI adjustment if we do want to try it.
NOTE: This only makes these headers work for display.
They aren't yet recognized as targets by the drag list UI, so you can't drag cards into an empty group. I'll tackle that in a followup.
Test Plan: {F6257686}
Reviewers: amckinley
Reviewed By: amckinley
Maniphest Tasks: T10333
Differential Revision: https://secure.phabricator.com/D20247
2019-03-05 15:00:12 +01:00
|
|
|
var header_keys = [];
|
|
|
|
var seen_headers = {};
|
|
|
|
if (has_headers) {
|
|
|
|
var header_templates = board.getHeaderTemplatesForOrder(order);
|
|
|
|
for (var k in header_templates) {
|
|
|
|
header_keys.push(header_templates[k].getHeaderKey());
|
|
|
|
}
|
|
|
|
header_keys.reverse();
|
|
|
|
}
|
|
|
|
|
|
|
|
for (ii = 0; ii < list.length; ii++) {
|
2016-02-10 22:53:36 +01:00
|
|
|
var card = list[ii];
|
|
|
|
|
Add priority group headers to workboard columns (display only)
Summary:
Ref T10333. When workboards are ordered (for example, by priority), add headers to the various groups. Major goals are:
- Allow users to drag-and-drop to set values that no cards currently have: for example, you can change a card priority to "normal" by dragging it under the "normal" header, even if no other cards in the column are currently "Normal".
- Make future orderings more useful, particularly "order by assignee". We don't really have room to put the username on every card and it would create a fair amount of clutter, but we can put usernames in these headers and then reference them with just the profile picture. This also allows you to assign to users who are not currently assigned anything in a given column.
- Make the drag-and-drop behavior more obvious by showing what it will do more clearly (see T8135).
- Make things a little easier to scan in general: because space on cards is limited, some information isn't conveyed very clearly (for example, priority information is currently conveyed //only// through color, which can be hard to pick out visually and is probably not functional for users who need vision accommodations).
- Maybe do "swimlanes": this is pretty much a "swimlanes" UI if we add whitespace at the bottom of each group so that the headers line up across all the columns (e.g., "Normal" is at the same y-axis position in every column as you scroll down the page). Not sold on this being useful, but it's just a UI adjustment if we do want to try it.
NOTE: This only makes these headers work for display.
They aren't yet recognized as targets by the drag list UI, so you can't drag cards into an empty group. I'll tackle that in a followup.
Test Plan: {F6257686}
Reviewers: amckinley
Reviewed By: amckinley
Maniphest Tasks: T10333
Differential Revision: https://secure.phabricator.com/D20247
2019-03-05 15:00:12 +01:00
|
|
|
// If a column has a "High" priority card and a "Low" priority card,
|
|
|
|
// we need to add the "Normal" header in between them. This allows
|
|
|
|
// you to change priority to "Normal" even if there are no "Normal"
|
|
|
|
// cards in a column.
|
|
|
|
|
|
|
|
if (has_headers) {
|
|
|
|
var header_key = this._getCardHeaderKey(card, order);
|
|
|
|
if (!seen_headers[header_key]) {
|
|
|
|
while (header_keys.length) {
|
|
|
|
var next = header_keys.pop();
|
|
|
|
|
|
|
|
var header = this.getHeader(next);
|
|
|
|
objects.push(header);
|
|
|
|
seen_headers[header_key] = true;
|
|
|
|
|
|
|
|
if (next === header_key) {
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
2016-02-10 22:53:36 +01:00
|
|
|
|
Add priority group headers to workboard columns (display only)
Summary:
Ref T10333. When workboards are ordered (for example, by priority), add headers to the various groups. Major goals are:
- Allow users to drag-and-drop to set values that no cards currently have: for example, you can change a card priority to "normal" by dragging it under the "normal" header, even if no other cards in the column are currently "Normal".
- Make future orderings more useful, particularly "order by assignee". We don't really have room to put the username on every card and it would create a fair amount of clutter, but we can put usernames in these headers and then reference them with just the profile picture. This also allows you to assign to users who are not currently assigned anything in a given column.
- Make the drag-and-drop behavior more obvious by showing what it will do more clearly (see T8135).
- Make things a little easier to scan in general: because space on cards is limited, some information isn't conveyed very clearly (for example, priority information is currently conveyed //only// through color, which can be hard to pick out visually and is probably not functional for users who need vision accommodations).
- Maybe do "swimlanes": this is pretty much a "swimlanes" UI if we add whitespace at the bottom of each group so that the headers line up across all the columns (e.g., "Normal" is at the same y-axis position in every column as you scroll down the page). Not sold on this being useful, but it's just a UI adjustment if we do want to try it.
NOTE: This only makes these headers work for display.
They aren't yet recognized as targets by the drag list UI, so you can't drag cards into an empty group. I'll tackle that in a followup.
Test Plan: {F6257686}
Reviewers: amckinley
Reviewed By: amckinley
Maniphest Tasks: T10333
Differential Revision: https://secure.phabricator.com/D20247
2019-03-05 15:00:12 +01:00
|
|
|
objects.push(card);
|
|
|
|
}
|
|
|
|
|
|
|
|
this._objects = objects;
|
|
|
|
|
|
|
|
var content = [];
|
|
|
|
for (ii = 0; ii < this._objects.length; ii++) {
|
|
|
|
var object = this._objects[ii];
|
|
|
|
|
|
|
|
var node = object.getNode();
|
|
|
|
content.push(node);
|
2016-02-10 14:59:46 +01:00
|
|
|
}
|
|
|
|
|
|
|
|
JX.DOM.setContent(this.getRoot(), content);
|
2016-02-10 22:53:36 +01:00
|
|
|
|
|
|
|
this._redrawFrame();
|
|
|
|
|
|
|
|
this._dirty = false;
|
2016-02-10 14:59:46 +01:00
|
|
|
},
|
|
|
|
|
When dragging nodes between different columns on an ordered board, don't reorder them by making secondary edits
Summary:
Ref T10334. When a workboard is ordered by priority, dragging from column "A" to a particular place in column "B" currently means "move this task to column B, and adjust its priority so that it naturally sorts into the location under my mouse cursor".
Users frequently find this confusing / undesirable.
To begin improving this, make "drag from column A to column B" and "drag from somewhere in column A to somewhere else in column A" into different operations. The first operation, a movement between columns, no longer implies an ordering change. The second action still does.
So if you actually want to change the priority of a task, you drag it within its current column. If you just want to move it to a different column, you drag it between columns.
This creates some possible problems:
- Some users may love the current behavior and just not be very vocal about it. I doubt it, but presumably we'll hear from them if we break it.
- If you actualy want to move + reorder, it's a bit more cumbersome now. We could possibly add something like "shift + drag" for this if there's feedback.
- The new behavior is probably less surprising, but may not be much more obvious. Future changes (for example, in T10335) should help make it more clear.
- When you mouse cursor goes over column B, the card dashed-rectangle preview target thing jumps to the correct position in the column -- but that may not be under your mouse cursor. This feels pretty much fine if the whole column fits on screen. It may not be so great if the column does not fit on screen and the dashed-rectangle-thing has vanished. This is just a UI feedback issue and we could refine this later (scroll/highlight the column).
Test Plan:
- Created several tasks at different priority levels, sorted a board by priority, dragged tasks between columns. Dragging from "A" to "B" no longer causes a priority edit.
- Also, dragged within a column. This still performs priority edits.
Reviewers: amckinley
Reviewed By: amckinley
Maniphest Tasks: T10334
Differential Revision: https://secure.phabricator.com/D20242
2019-03-02 00:13:25 +01:00
|
|
|
compareHandler: function(src_list, src_node, dst_list, dst_node) {
|
|
|
|
var board = this.getBoard();
|
|
|
|
var order = board.getOrder();
|
|
|
|
|
Make drag-and-drop on workboards interact with priority column headers
Summary:
Ref T10333. Ref T8135. Depends on D20247. Allow users to drag-and-drop cards on a priority-sorted workboard under headers, even if the header has no other cards.
As of D20247, headers show up but they aren't really interactive. Now, you can drag cards directly underneath a header (instead of only between other cards). For example, if a column has only one "Wishlist" task, you may drag it under the "High", "Normal", or "Low" priority headers to select a specific priority.
(Some of this code still feels a little rough, but I think it will generalize once other types of sorting are available.)
Test Plan: Dragged cards within and between priority groups, saw appropriate priority edits applied in every case I could come up with.
Reviewers: amckinley
Reviewed By: amckinley
Maniphest Tasks: T10333, T8135
Differential Revision: https://secure.phabricator.com/D20248
2019-03-05 16:38:35 +01:00
|
|
|
var u_vec = this._getNodeOrderVector(src_node, order);
|
|
|
|
var v_vec = this._getNodeOrderVector(dst_node, order);
|
When dragging nodes between different columns on an ordered board, don't reorder them by making secondary edits
Summary:
Ref T10334. When a workboard is ordered by priority, dragging from column "A" to a particular place in column "B" currently means "move this task to column B, and adjust its priority so that it naturally sorts into the location under my mouse cursor".
Users frequently find this confusing / undesirable.
To begin improving this, make "drag from column A to column B" and "drag from somewhere in column A to somewhere else in column A" into different operations. The first operation, a movement between columns, no longer implies an ordering change. The second action still does.
So if you actually want to change the priority of a task, you drag it within its current column. If you just want to move it to a different column, you drag it between columns.
This creates some possible problems:
- Some users may love the current behavior and just not be very vocal about it. I doubt it, but presumably we'll hear from them if we break it.
- If you actualy want to move + reorder, it's a bit more cumbersome now. We could possibly add something like "shift + drag" for this if there's feedback.
- The new behavior is probably less surprising, but may not be much more obvious. Future changes (for example, in T10335) should help make it more clear.
- When you mouse cursor goes over column B, the card dashed-rectangle preview target thing jumps to the correct position in the column -- but that may not be under your mouse cursor. This feels pretty much fine if the whole column fits on screen. It may not be so great if the column does not fit on screen and the dashed-rectangle-thing has vanished. This is just a UI feedback issue and we could refine this later (scroll/highlight the column).
Test Plan:
- Created several tasks at different priority levels, sorted a board by priority, dragged tasks between columns. Dragging from "A" to "B" no longer causes a priority edit.
- Also, dragged within a column. This still performs priority edits.
Reviewers: amckinley
Reviewed By: amckinley
Maniphest Tasks: T10334
Differential Revision: https://secure.phabricator.com/D20242
2019-03-02 00:13:25 +01:00
|
|
|
|
Add priority group headers to workboard columns (display only)
Summary:
Ref T10333. When workboards are ordered (for example, by priority), add headers to the various groups. Major goals are:
- Allow users to drag-and-drop to set values that no cards currently have: for example, you can change a card priority to "normal" by dragging it under the "normal" header, even if no other cards in the column are currently "Normal".
- Make future orderings more useful, particularly "order by assignee". We don't really have room to put the username on every card and it would create a fair amount of clutter, but we can put usernames in these headers and then reference them with just the profile picture. This also allows you to assign to users who are not currently assigned anything in a given column.
- Make the drag-and-drop behavior more obvious by showing what it will do more clearly (see T8135).
- Make things a little easier to scan in general: because space on cards is limited, some information isn't conveyed very clearly (for example, priority information is currently conveyed //only// through color, which can be hard to pick out visually and is probably not functional for users who need vision accommodations).
- Maybe do "swimlanes": this is pretty much a "swimlanes" UI if we add whitespace at the bottom of each group so that the headers line up across all the columns (e.g., "Normal" is at the same y-axis position in every column as you scroll down the page). Not sold on this being useful, but it's just a UI adjustment if we do want to try it.
NOTE: This only makes these headers work for display.
They aren't yet recognized as targets by the drag list UI, so you can't drag cards into an empty group. I'll tackle that in a followup.
Test Plan: {F6257686}
Reviewers: amckinley
Reviewed By: amckinley
Maniphest Tasks: T10333
Differential Revision: https://secure.phabricator.com/D20247
2019-03-05 15:00:12 +01:00
|
|
|
return board.compareVectors(u_vec, v_vec);
|
When dragging nodes between different columns on an ordered board, don't reorder them by making secondary edits
Summary:
Ref T10334. When a workboard is ordered by priority, dragging from column "A" to a particular place in column "B" currently means "move this task to column B, and adjust its priority so that it naturally sorts into the location under my mouse cursor".
Users frequently find this confusing / undesirable.
To begin improving this, make "drag from column A to column B" and "drag from somewhere in column A to somewhere else in column A" into different operations. The first operation, a movement between columns, no longer implies an ordering change. The second action still does.
So if you actually want to change the priority of a task, you drag it within its current column. If you just want to move it to a different column, you drag it between columns.
This creates some possible problems:
- Some users may love the current behavior and just not be very vocal about it. I doubt it, but presumably we'll hear from them if we break it.
- If you actualy want to move + reorder, it's a bit more cumbersome now. We could possibly add something like "shift + drag" for this if there's feedback.
- The new behavior is probably less surprising, but may not be much more obvious. Future changes (for example, in T10335) should help make it more clear.
- When you mouse cursor goes over column B, the card dashed-rectangle preview target thing jumps to the correct position in the column -- but that may not be under your mouse cursor. This feels pretty much fine if the whole column fits on screen. It may not be so great if the column does not fit on screen and the dashed-rectangle-thing has vanished. This is just a UI feedback issue and we could refine this later (scroll/highlight the column).
Test Plan:
- Created several tasks at different priority levels, sorted a board by priority, dragged tasks between columns. Dragging from "A" to "B" no longer causes a priority edit.
- Also, dragged within a column. This still performs priority edits.
Reviewers: amckinley
Reviewed By: amckinley
Maniphest Tasks: T10334
Differential Revision: https://secure.phabricator.com/D20242
2019-03-02 00:13:25 +01:00
|
|
|
},
|
|
|
|
|
Make drag-and-drop on workboards interact with priority column headers
Summary:
Ref T10333. Ref T8135. Depends on D20247. Allow users to drag-and-drop cards on a priority-sorted workboard under headers, even if the header has no other cards.
As of D20247, headers show up but they aren't really interactive. Now, you can drag cards directly underneath a header (instead of only between other cards). For example, if a column has only one "Wishlist" task, you may drag it under the "High", "Normal", or "Low" priority headers to select a specific priority.
(Some of this code still feels a little rough, but I think it will generalize once other types of sorting are available.)
Test Plan: Dragged cards within and between priority groups, saw appropriate priority edits applied in every case I could come up with.
Reviewers: amckinley
Reviewed By: amckinley
Maniphest Tasks: T10333, T8135
Differential Revision: https://secure.phabricator.com/D20248
2019-03-05 16:38:35 +01:00
|
|
|
_getNodeOrderVector: function(node, order) {
|
|
|
|
var board = this.getBoard();
|
|
|
|
var data = JX.Stratcom.getData(node);
|
|
|
|
|
|
|
|
if (data.objectPHID) {
|
|
|
|
return board.getOrderVector(data.objectPHID, order);
|
|
|
|
}
|
|
|
|
|
|
|
|
return board.getHeaderTemplate(data.headerKey).getVector();
|
|
|
|
},
|
|
|
|
|
2019-03-02 16:45:51 +01:00
|
|
|
setIsDropTarget: function(is_target) {
|
|
|
|
var node = this.getWorkpanelNode();
|
|
|
|
JX.DOM.alterClass(node, 'workboard-column-drop-target', is_target);
|
|
|
|
},
|
|
|
|
|
2016-02-10 14:59:46 +01:00
|
|
|
_getCardsSortedNaturally: function() {
|
|
|
|
var list = [];
|
|
|
|
|
|
|
|
for (var ii = 0; ii < this._naturalOrder.length; ii++) {
|
|
|
|
var phid = this._naturalOrder[ii];
|
|
|
|
list.push(this.getCard(phid));
|
|
|
|
}
|
|
|
|
|
|
|
|
return list;
|
|
|
|
},
|
|
|
|
|
|
|
|
_getCardsSortedByKey: function(order) {
|
|
|
|
var cards = this.getCards();
|
|
|
|
|
|
|
|
var list = [];
|
|
|
|
for (var k in cards) {
|
|
|
|
list.push(cards[k]);
|
|
|
|
}
|
|
|
|
|
|
|
|
list.sort(JX.bind(this, this._sortCards, order));
|
|
|
|
|
|
|
|
return list;
|
|
|
|
},
|
|
|
|
|
|
|
|
_sortCards: function(order, u, v) {
|
Add priority group headers to workboard columns (display only)
Summary:
Ref T10333. When workboards are ordered (for example, by priority), add headers to the various groups. Major goals are:
- Allow users to drag-and-drop to set values that no cards currently have: for example, you can change a card priority to "normal" by dragging it under the "normal" header, even if no other cards in the column are currently "Normal".
- Make future orderings more useful, particularly "order by assignee". We don't really have room to put the username on every card and it would create a fair amount of clutter, but we can put usernames in these headers and then reference them with just the profile picture. This also allows you to assign to users who are not currently assigned anything in a given column.
- Make the drag-and-drop behavior more obvious by showing what it will do more clearly (see T8135).
- Make things a little easier to scan in general: because space on cards is limited, some information isn't conveyed very clearly (for example, priority information is currently conveyed //only// through color, which can be hard to pick out visually and is probably not functional for users who need vision accommodations).
- Maybe do "swimlanes": this is pretty much a "swimlanes" UI if we add whitespace at the bottom of each group so that the headers line up across all the columns (e.g., "Normal" is at the same y-axis position in every column as you scroll down the page). Not sold on this being useful, but it's just a UI adjustment if we do want to try it.
NOTE: This only makes these headers work for display.
They aren't yet recognized as targets by the drag list UI, so you can't drag cards into an empty group. I'll tackle that in a followup.
Test Plan: {F6257686}
Reviewers: amckinley
Reviewed By: amckinley
Maniphest Tasks: T10333
Differential Revision: https://secure.phabricator.com/D20247
2019-03-05 15:00:12 +01:00
|
|
|
var board = this.getBoard();
|
|
|
|
var u_vec = board.getOrderVector(u.getPHID(), order);
|
|
|
|
var v_vec = board.getOrderVector(v.getPHID(), order);
|
2016-02-10 14:59:46 +01:00
|
|
|
|
Add priority group headers to workboard columns (display only)
Summary:
Ref T10333. When workboards are ordered (for example, by priority), add headers to the various groups. Major goals are:
- Allow users to drag-and-drop to set values that no cards currently have: for example, you can change a card priority to "normal" by dragging it under the "normal" header, even if no other cards in the column are currently "Normal".
- Make future orderings more useful, particularly "order by assignee". We don't really have room to put the username on every card and it would create a fair amount of clutter, but we can put usernames in these headers and then reference them with just the profile picture. This also allows you to assign to users who are not currently assigned anything in a given column.
- Make the drag-and-drop behavior more obvious by showing what it will do more clearly (see T8135).
- Make things a little easier to scan in general: because space on cards is limited, some information isn't conveyed very clearly (for example, priority information is currently conveyed //only// through color, which can be hard to pick out visually and is probably not functional for users who need vision accommodations).
- Maybe do "swimlanes": this is pretty much a "swimlanes" UI if we add whitespace at the bottom of each group so that the headers line up across all the columns (e.g., "Normal" is at the same y-axis position in every column as you scroll down the page). Not sold on this being useful, but it's just a UI adjustment if we do want to try it.
NOTE: This only makes these headers work for display.
They aren't yet recognized as targets by the drag list UI, so you can't drag cards into an empty group. I'll tackle that in a followup.
Test Plan: {F6257686}
Reviewers: amckinley
Reviewed By: amckinley
Maniphest Tasks: T10333
Differential Revision: https://secure.phabricator.com/D20247
2019-03-05 15:00:12 +01:00
|
|
|
return board.compareVectors(u_vec, v_vec);
|
2016-02-10 22:53:36 +01:00
|
|
|
},
|
|
|
|
|
|
|
|
_redrawFrame: function() {
|
|
|
|
var cards = this.getCards();
|
|
|
|
var board = this.getBoard();
|
|
|
|
|
|
|
|
var points = {};
|
2016-03-11 03:54:17 +01:00
|
|
|
var count = 0;
|
2016-09-27 18:29:43 +02:00
|
|
|
var decimal_places = 0;
|
2016-02-10 22:53:36 +01:00
|
|
|
for (var phid in cards) {
|
|
|
|
var card = cards[phid];
|
|
|
|
|
|
|
|
var card_points;
|
|
|
|
if (board.getPointsEnabled()) {
|
|
|
|
card_points = card.getPoints();
|
|
|
|
} else {
|
|
|
|
card_points = 1;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (card_points !== null) {
|
|
|
|
var status = card.getStatus();
|
|
|
|
if (!points[status]) {
|
|
|
|
points[status] = 0;
|
|
|
|
}
|
|
|
|
points[status] += card_points;
|
2016-09-27 18:29:43 +02:00
|
|
|
|
|
|
|
// Count the number of decimal places in the point value with the
|
|
|
|
// most decimal digits. We'll use the same precision when rendering
|
|
|
|
// the point sum. This avoids rounding errors and makes the display
|
|
|
|
// a little more consistent.
|
|
|
|
var parts = card_points.toString().split('.');
|
|
|
|
if (parts[1]) {
|
|
|
|
decimal_places = Math.max(decimal_places, parts[1].length);
|
|
|
|
}
|
2016-02-10 22:53:36 +01:00
|
|
|
}
|
2016-03-11 03:54:17 +01:00
|
|
|
|
|
|
|
count++;
|
2016-02-10 22:53:36 +01:00
|
|
|
}
|
|
|
|
|
|
|
|
var total_points = 0;
|
|
|
|
for (var k in points) {
|
|
|
|
total_points += points[k];
|
|
|
|
}
|
2016-09-27 18:29:43 +02:00
|
|
|
total_points = total_points.toFixed(decimal_places);
|
2016-02-10 22:53:36 +01:00
|
|
|
|
|
|
|
var limit = this.getPointLimit();
|
|
|
|
|
|
|
|
var display_value;
|
|
|
|
if (limit !== null && limit !== 0) {
|
|
|
|
display_value = total_points + ' / ' + limit;
|
|
|
|
} else {
|
|
|
|
display_value = total_points;
|
|
|
|
}
|
|
|
|
|
2016-03-11 03:54:17 +01:00
|
|
|
if (board.getPointsEnabled()) {
|
|
|
|
display_value = count + ' | ' + display_value;
|
|
|
|
}
|
|
|
|
|
2016-02-10 22:53:36 +01:00
|
|
|
var over_limit = ((limit !== null) && (total_points > limit));
|
|
|
|
|
|
|
|
var content_node = this.getPointsContentNode();
|
|
|
|
var points_node = this.getPointsNode();
|
|
|
|
|
|
|
|
JX.DOM.setContent(content_node, display_value);
|
|
|
|
|
|
|
|
var is_empty = !this.getCardPHIDs().length;
|
|
|
|
var panel = JX.DOM.findAbove(this.getRoot(), 'div', 'workpanel');
|
|
|
|
JX.DOM.alterClass(panel, 'project-panel-empty', is_empty);
|
|
|
|
JX.DOM.alterClass(panel, 'project-panel-over-limit', over_limit);
|
|
|
|
|
|
|
|
var color_map = {
|
2017-05-22 19:47:19 +02:00
|
|
|
'phui-tag-disabled': (total_points === 0),
|
|
|
|
'phui-tag-blue': (total_points > 0 && !over_limit),
|
|
|
|
'phui-tag-red': (over_limit)
|
2016-02-10 22:53:36 +01:00
|
|
|
};
|
|
|
|
|
|
|
|
for (var c in color_map) {
|
|
|
|
JX.DOM.alterClass(points_node, c, !!color_map[c]);
|
|
|
|
}
|
|
|
|
|
|
|
|
JX.DOM.show(points_node);
|
2016-02-10 14:59:46 +01:00
|
|
|
}
|
|
|
|
|
|
|
|
}
|
|
|
|
|
|
|
|
});
|