revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-23 22:10:55 +01:00
Code Issues Releases Wiki Activity
phorge-phorge/resources/sql/autopatches/20160223.paste.fileedges.php

12 lines
495 B
PHP
Raw Normal View History

Correct an old issue with Paste by restoring the file attachment edge Summary: I'm having trouble figuring out exactly what the timeframe on this was, but for a while in November we were not writing edges between pastes and their attached files correctly. An example of this on this install is here: https://secure.phabricator.com/P1893 That will start working once the migration runs, but until it does it shows this: {F1126605} This got fixed so recent stuff works fine, but it looks like WMF updated while the bug was active so they have more affected pastes than we do (we only have about 10). Test Plan: Ran this query to find pastes with missing edges: ``` select id, FROM_UNIXTIME(p.dateCreated) from pastebin_paste p LEFT JOIN edge ON edge.src = p.phid AND edge.type = 25 WHERE edge.dst IS NULL order by id; ``` Ran the migration. Verified the edges were fixed. Viewed one of the affected pastes, things now worked properly. Reviewers: chad Reviewed By: chad Subscribers: 20after4 Differential Revision: https://secure.phabricator.com/D15340
2016-02-24 02:21:27 +01:00
<?php
// For a while in November 2015, attachment edges between pastes and their
// underlying file data were not written correctly. This restores edges for
// any missing pastes.
No-op an ancient Paste edge migration which no longer functions after a database rename Summary: Fixes T13510. This migration currently fails because it tries to affect the "paste" database, but when it runs this database will be named "pastebin". Since the cost of fixing it in place or moving it past the rename migration both seem relatively high (and the cost of throwing it away is plausibly zero) just throw it for now. Test Plan: Looked at file, saw no more code that can execute. Subscribers: PHID-OPKG-gm6ozazyms6q6i22gyam Maniphest Tasks: T13510 Differential Revision: https://secure.phabricator.com/D21132
2020-04-17 14:30:55 +02:00
// See T13510. The "pastebin" database was later renamed to "paste", which
// broke this migration. The migration was removed in 2020 since it seems
// plausible that zero installs are impacted (only installs that ran code
// from November 2015 and have not upgraded in five years could possibly be
// impacted).
Copy permalink