2011-02-19 07:15:28 +01:00
|
|
|
<?php
|
|
|
|
|
Rename Conduit classes
Summary: Ref T5655. Rename Conduit classes and provide a `getAPIMethodName` method to declare the API method.
Test Plan:
```
> echo '{}' | arc --conduit-uri='http://phabricator.joshuaspence.com' call-conduit user.whoami
Waiting for JSON parameters on stdin...
{"error":null,"errorMessage":null,"response":{"phid":"PHID-USER-lioqffnwn6y475mu5ndb","userName":"josh","realName":"Joshua Spence","image":"http:\/\/phabricator.joshuaspence.com\/res\/1404425321T\/phabricator\/3eb28cd9\/rsrc\/image\/avatar.png","uri":"http:\/\/phabricator.joshuaspence.com\/p\/josh\/","roles":["admin","verified","approved","activated"]}}
```
Reviewers: epriestley, #blessed_reviewers
Reviewed By: epriestley, #blessed_reviewers
Subscribers: epriestley, Korvin, hach-que
Maniphest Tasks: T5655
Differential Revision: https://secure.phabricator.com/D9991
2014-07-25 02:54:15 +02:00
|
|
|
final class DifferentialGetDiffConduitAPIMethod
|
|
|
|
extends DifferentialConduitAPIMethod {
|
|
|
|
|
|
|
|
public function getAPIMethodName() {
|
|
|
|
return 'differential.getdiff';
|
|
|
|
}
|
2013-09-17 22:55:41 +02:00
|
|
|
|
2013-11-12 01:05:19 +01:00
|
|
|
public function shouldAllowPublic() {
|
|
|
|
return true;
|
|
|
|
}
|
|
|
|
|
2013-09-17 22:55:41 +02:00
|
|
|
public function getMethodStatus() {
|
|
|
|
return self::METHOD_STATUS_DEPRECATED;
|
|
|
|
}
|
|
|
|
|
|
|
|
public function getMethodStatusDescription() {
|
|
|
|
return pht(
|
|
|
|
'This method has been deprecated in favor of differential.querydiffs.');
|
|
|
|
}
|
|
|
|
|
2011-02-19 07:15:28 +01:00
|
|
|
|
|
|
|
public function getMethodDescription() {
|
2013-09-17 22:55:41 +02:00
|
|
|
return pht('Load the content of a diff from Differential by revision id '.
|
|
|
|
'or diff id.');
|
2011-02-19 07:15:28 +01:00
|
|
|
}
|
|
|
|
|
|
|
|
public function defineParamTypes() {
|
|
|
|
return array(
|
|
|
|
'revision_id' => 'optional id',
|
|
|
|
'diff_id' => 'optional id',
|
|
|
|
);
|
|
|
|
}
|
|
|
|
|
|
|
|
public function defineReturnType() {
|
|
|
|
return 'nonempty dict';
|
|
|
|
}
|
|
|
|
|
|
|
|
public function defineErrorTypes() {
|
|
|
|
return array(
|
|
|
|
'ERR_BAD_DIFF' => 'No such diff exists.',
|
|
|
|
);
|
|
|
|
}
|
|
|
|
|
|
|
|
protected function execute(ConduitAPIRequest $request) {
|
2013-09-19 00:31:48 +02:00
|
|
|
$diff_id = $request->getValue('diff_id');
|
2011-02-19 07:15:28 +01:00
|
|
|
|
2013-09-19 00:31:48 +02:00
|
|
|
// If we have a revision ID, we need the most recent diff. Figure that out
|
|
|
|
// without loading all the attached data.
|
2011-02-19 07:15:28 +01:00
|
|
|
$revision_id = $request->getValue('revision_id');
|
|
|
|
if ($revision_id) {
|
2013-09-19 00:31:48 +02:00
|
|
|
$diffs = id(new DifferentialDiffQuery())
|
|
|
|
->setViewer($request->getUser())
|
|
|
|
->withRevisionIDs(array($revision_id))
|
|
|
|
->execute();
|
|
|
|
if ($diffs) {
|
|
|
|
$diff_id = head($diffs)->getID();
|
|
|
|
} else {
|
|
|
|
throw new ConduitException('ERR_BAD_DIFF');
|
|
|
|
}
|
2011-02-19 07:15:28 +01:00
|
|
|
}
|
2013-09-19 00:31:48 +02:00
|
|
|
|
|
|
|
$diff = null;
|
2013-09-17 22:55:41 +02:00
|
|
|
if ($diff_id) {
|
|
|
|
$diff = id(new DifferentialDiffQuery())
|
|
|
|
->setViewer($request->getUser())
|
2013-09-19 00:31:48 +02:00
|
|
|
->withIDs(array($diff_id))
|
2013-09-17 22:55:41 +02:00
|
|
|
->needChangesets(true)
|
|
|
|
->needArcanistProjects(true)
|
|
|
|
->executeOne();
|
2011-02-19 07:15:28 +01:00
|
|
|
}
|
|
|
|
|
2013-09-17 22:55:41 +02:00
|
|
|
if (!$diff) {
|
|
|
|
throw new ConduitException('ERR_BAD_DIFF');
|
2011-11-29 23:55:50 +01:00
|
|
|
}
|
|
|
|
|
2013-09-17 22:55:41 +02:00
|
|
|
return $diff->getDiffDict();
|
2011-02-19 07:15:28 +01:00
|
|
|
}
|
|
|
|
|
|
|
|
}
|