Add very basic scaffolding for Pholio
Summary:
I'm not going to land this until it's a bit more fleshed out since it would just confuse users, but this is probably more reviewable as a few diffs adding a couple features than one ULTRA-diff adding everything. Implement application basics for Pholio. This does more or less nothing, but adds storage, subscribe, flag, markup, indexing, query basics, PHIDs, handle loads, a couple of realy really basic controllers, etc.
Basic hierarchy is:
- **Moleskine**: Top-level object like a Differential Revision, like "Ponder Feed Ideas".
- **Image**: Each Moleskine has one or more images, like the unexpanded / expanded / mobile / empty states of feed.
- **Transaction**: Comment or edit, like Maniphest. I generally want to move most apps to a transaction model so we can log edits.
- **PixelComment**: Equivalent of an inline comment.
Test Plan: Created a fake object and viewed it.
Reviewers: btrahan, chad
Reviewed By: btrahan
CC: aran, davidreuss
Maniphest Tasks: T2097
Differential Revision: https://secure.phabricator.com/D3817
2012-11-22 02:22:36 +01:00
|
|
|
<?php
|
|
|
|
|
|
|
|
/**
|
|
|
|
* @group pholio
|
|
|
|
*/
|
|
|
|
final class PholioMockViewController extends PholioController {
|
|
|
|
|
|
|
|
private $id;
|
|
|
|
|
|
|
|
public function willProcessRequest(array $data) {
|
|
|
|
$this->id = $data['id'];
|
|
|
|
}
|
|
|
|
|
|
|
|
public function processRequest() {
|
|
|
|
$request = $this->getRequest();
|
|
|
|
$user = $request->getUser();
|
|
|
|
|
|
|
|
$mock = id(new PholioMockQuery())
|
|
|
|
->setViewer($user)
|
|
|
|
->withIDs(array($this->id))
|
|
|
|
->executeOne();
|
|
|
|
|
|
|
|
if (!$mock) {
|
|
|
|
return new Aphront404Response();
|
|
|
|
}
|
|
|
|
|
2012-11-22 02:27:20 +01:00
|
|
|
$xactions = id(new PholioTransactionQuery())
|
|
|
|
->withMockIDs(array($mock->getID()))
|
|
|
|
->execute();
|
|
|
|
|
2012-11-22 02:38:57 +01:00
|
|
|
$subscribers = PhabricatorSubscribersQuery::loadSubscribersForPHID(
|
|
|
|
$mock->getPHID());
|
2012-11-22 02:27:20 +01:00
|
|
|
|
2012-11-22 02:24:01 +01:00
|
|
|
$phids = array();
|
|
|
|
$phids[] = $mock->getAuthorPHID();
|
2012-11-22 02:27:20 +01:00
|
|
|
foreach ($xactions as $xaction) {
|
|
|
|
$phids[] = $xaction->getAuthorPHID();
|
2012-11-22 02:38:57 +01:00
|
|
|
foreach ($xaction->getRequiredHandlePHIDs() as $hphid) {
|
|
|
|
$phids[] = $hphid;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
foreach ($subscribers as $subscriber) {
|
|
|
|
$phids[] = $subscriber;
|
2012-11-22 02:27:20 +01:00
|
|
|
}
|
2012-11-22 02:24:01 +01:00
|
|
|
$this->loadHandles($phids);
|
|
|
|
|
|
|
|
|
|
|
|
$engine = id(new PhabricatorMarkupEngine())
|
|
|
|
->setViewer($user);
|
|
|
|
$engine->addObject($mock, PholioMock::MARKUP_FIELD_DESCRIPTION);
|
2012-11-22 02:27:20 +01:00
|
|
|
foreach ($xactions as $xaction) {
|
|
|
|
$engine->addObject($xaction, PholioTransaction::MARKUP_FIELD_COMMENT);
|
|
|
|
}
|
2012-11-22 02:24:01 +01:00
|
|
|
$engine->process();
|
|
|
|
|
Add very basic scaffolding for Pholio
Summary:
I'm not going to land this until it's a bit more fleshed out since it would just confuse users, but this is probably more reviewable as a few diffs adding a couple features than one ULTRA-diff adding everything. Implement application basics for Pholio. This does more or less nothing, but adds storage, subscribe, flag, markup, indexing, query basics, PHIDs, handle loads, a couple of realy really basic controllers, etc.
Basic hierarchy is:
- **Moleskine**: Top-level object like a Differential Revision, like "Ponder Feed Ideas".
- **Image**: Each Moleskine has one or more images, like the unexpanded / expanded / mobile / empty states of feed.
- **Transaction**: Comment or edit, like Maniphest. I generally want to move most apps to a transaction model so we can log edits.
- **PixelComment**: Equivalent of an inline comment.
Test Plan: Created a fake object and viewed it.
Reviewers: btrahan, chad
Reviewed By: btrahan
CC: aran, davidreuss
Maniphest Tasks: T2097
Differential Revision: https://secure.phabricator.com/D3817
2012-11-22 02:22:36 +01:00
|
|
|
$title = 'M'.$mock->getID().' '.$mock->getName();
|
|
|
|
|
|
|
|
$header = id(new PhabricatorHeaderView())
|
|
|
|
->setHeader($title);
|
|
|
|
|
2012-11-22 02:24:01 +01:00
|
|
|
$actions = $this->buildActionView($mock);
|
2012-11-22 02:38:57 +01:00
|
|
|
$properties = $this->buildPropertyView($mock, $engine, $subscribers);
|
Add very basic scaffolding for Pholio
Summary:
I'm not going to land this until it's a bit more fleshed out since it would just confuse users, but this is probably more reviewable as a few diffs adding a couple features than one ULTRA-diff adding everything. Implement application basics for Pholio. This does more or less nothing, but adds storage, subscribe, flag, markup, indexing, query basics, PHIDs, handle loads, a couple of realy really basic controllers, etc.
Basic hierarchy is:
- **Moleskine**: Top-level object like a Differential Revision, like "Ponder Feed Ideas".
- **Image**: Each Moleskine has one or more images, like the unexpanded / expanded / mobile / empty states of feed.
- **Transaction**: Comment or edit, like Maniphest. I generally want to move most apps to a transaction model so we can log edits.
- **PixelComment**: Equivalent of an inline comment.
Test Plan: Created a fake object and viewed it.
Reviewers: btrahan, chad
Reviewed By: btrahan
CC: aran, davidreuss
Maniphest Tasks: T2097
Differential Revision: https://secure.phabricator.com/D3817
2012-11-22 02:22:36 +01:00
|
|
|
|
2012-11-22 02:24:01 +01:00
|
|
|
$carousel =
|
|
|
|
'<h1 style="margin: 2em; padding: 1em; border: 1px dashed grey;">'.
|
|
|
|
'Carousel Goes Here</h1>';
|
2012-11-22 02:27:20 +01:00
|
|
|
|
|
|
|
$xaction_view = $this->buildTransactionView($xactions, $engine);
|
|
|
|
|
2012-11-22 02:24:01 +01:00
|
|
|
$add_comment = $this->buildAddCommentView($mock);
|
Add very basic scaffolding for Pholio
Summary:
I'm not going to land this until it's a bit more fleshed out since it would just confuse users, but this is probably more reviewable as a few diffs adding a couple features than one ULTRA-diff adding everything. Implement application basics for Pholio. This does more or less nothing, but adds storage, subscribe, flag, markup, indexing, query basics, PHIDs, handle loads, a couple of realy really basic controllers, etc.
Basic hierarchy is:
- **Moleskine**: Top-level object like a Differential Revision, like "Ponder Feed Ideas".
- **Image**: Each Moleskine has one or more images, like the unexpanded / expanded / mobile / empty states of feed.
- **Transaction**: Comment or edit, like Maniphest. I generally want to move most apps to a transaction model so we can log edits.
- **PixelComment**: Equivalent of an inline comment.
Test Plan: Created a fake object and viewed it.
Reviewers: btrahan, chad
Reviewed By: btrahan
CC: aran, davidreuss
Maniphest Tasks: T2097
Differential Revision: https://secure.phabricator.com/D3817
2012-11-22 02:22:36 +01:00
|
|
|
|
|
|
|
$content = array(
|
|
|
|
$header,
|
|
|
|
$actions,
|
2012-11-22 02:24:01 +01:00
|
|
|
$properties,
|
|
|
|
$carousel,
|
2012-11-22 02:27:20 +01:00
|
|
|
$xaction_view,
|
2012-11-22 02:24:01 +01:00
|
|
|
$add_comment,
|
Add very basic scaffolding for Pholio
Summary:
I'm not going to land this until it's a bit more fleshed out since it would just confuse users, but this is probably more reviewable as a few diffs adding a couple features than one ULTRA-diff adding everything. Implement application basics for Pholio. This does more or less nothing, but adds storage, subscribe, flag, markup, indexing, query basics, PHIDs, handle loads, a couple of realy really basic controllers, etc.
Basic hierarchy is:
- **Moleskine**: Top-level object like a Differential Revision, like "Ponder Feed Ideas".
- **Image**: Each Moleskine has one or more images, like the unexpanded / expanded / mobile / empty states of feed.
- **Transaction**: Comment or edit, like Maniphest. I generally want to move most apps to a transaction model so we can log edits.
- **PixelComment**: Equivalent of an inline comment.
Test Plan: Created a fake object and viewed it.
Reviewers: btrahan, chad
Reviewed By: btrahan
CC: aran, davidreuss
Maniphest Tasks: T2097
Differential Revision: https://secure.phabricator.com/D3817
2012-11-22 02:22:36 +01:00
|
|
|
);
|
|
|
|
|
|
|
|
return $this->buildApplicationPage(
|
|
|
|
$content,
|
|
|
|
array(
|
|
|
|
'title' => $title,
|
2012-11-22 02:24:01 +01:00
|
|
|
'device' => true,
|
Add very basic scaffolding for Pholio
Summary:
I'm not going to land this until it's a bit more fleshed out since it would just confuse users, but this is probably more reviewable as a few diffs adding a couple features than one ULTRA-diff adding everything. Implement application basics for Pholio. This does more or less nothing, but adds storage, subscribe, flag, markup, indexing, query basics, PHIDs, handle loads, a couple of realy really basic controllers, etc.
Basic hierarchy is:
- **Moleskine**: Top-level object like a Differential Revision, like "Ponder Feed Ideas".
- **Image**: Each Moleskine has one or more images, like the unexpanded / expanded / mobile / empty states of feed.
- **Transaction**: Comment or edit, like Maniphest. I generally want to move most apps to a transaction model so we can log edits.
- **PixelComment**: Equivalent of an inline comment.
Test Plan: Created a fake object and viewed it.
Reviewers: btrahan, chad
Reviewed By: btrahan
CC: aran, davidreuss
Maniphest Tasks: T2097
Differential Revision: https://secure.phabricator.com/D3817
2012-11-22 02:22:36 +01:00
|
|
|
));
|
|
|
|
}
|
|
|
|
|
2012-11-22 02:24:01 +01:00
|
|
|
private function buildActionView(PholioMock $mock) {
|
|
|
|
$user = $this->getRequest()->getUser();
|
|
|
|
|
|
|
|
$actions = id(new PhabricatorActionListView())
|
|
|
|
->setUser($user)
|
|
|
|
->setObject($mock);
|
|
|
|
|
|
|
|
$can_edit = PhabricatorPolicyFilter::hasCapability(
|
|
|
|
$user,
|
|
|
|
$mock,
|
|
|
|
PhabricatorPolicyCapability::CAN_EDIT);
|
|
|
|
|
|
|
|
$actions->addAction(
|
|
|
|
id(new PhabricatorActionView())
|
|
|
|
->setIcon('edit')
|
|
|
|
->setName(pht('Edit Mock'))
|
|
|
|
->setHref($this->getApplicationURI('/edit/'.$mock->getID()))
|
|
|
|
->setDisabled(!$can_edit)
|
|
|
|
->setWorkflow(!$can_edit));
|
|
|
|
|
|
|
|
return $actions;
|
|
|
|
}
|
|
|
|
|
|
|
|
private function buildPropertyView(
|
|
|
|
PholioMock $mock,
|
2012-11-22 02:38:57 +01:00
|
|
|
PhabricatorMarkupEngine $engine,
|
|
|
|
array $subscribers) {
|
2012-11-22 02:24:01 +01:00
|
|
|
|
|
|
|
$user = $this->getRequest()->getUser();
|
|
|
|
|
|
|
|
$properties = new PhabricatorPropertyListView();
|
|
|
|
|
|
|
|
$properties->addProperty(
|
|
|
|
pht('Author'),
|
|
|
|
$this->getHandle($mock->getAuthorPHID())->renderLink());
|
|
|
|
|
|
|
|
$properties->addProperty(
|
|
|
|
pht('Created'),
|
|
|
|
phabricator_datetime($mock->getDateCreated(), $user));
|
|
|
|
|
|
|
|
$descriptions = PhabricatorPolicyQuery::renderPolicyDescriptions(
|
|
|
|
$user,
|
|
|
|
$mock);
|
|
|
|
|
|
|
|
$properties->addProperty(
|
|
|
|
pht('Visible To'),
|
|
|
|
$descriptions[PhabricatorPolicyCapability::CAN_VIEW]);
|
|
|
|
|
2012-11-22 02:38:57 +01:00
|
|
|
if ($subscribers) {
|
|
|
|
$sub_view = array();
|
|
|
|
foreach ($subscribers as $subscriber) {
|
|
|
|
$sub_view[] = $this->getHandle($subscriber)->renderLink();
|
|
|
|
}
|
|
|
|
$sub_view = implode(', ', $sub_view);
|
|
|
|
} else {
|
|
|
|
$sub_view = '<em>'.pht('None').'</em>';
|
|
|
|
}
|
|
|
|
|
|
|
|
$properties->addProperty(
|
|
|
|
pht('Subscribers'),
|
|
|
|
$sub_view);
|
|
|
|
|
2012-11-22 02:24:01 +01:00
|
|
|
$properties->addTextContent(
|
|
|
|
$engine->getOutput($mock, PholioMock::MARKUP_FIELD_DESCRIPTION));
|
|
|
|
|
|
|
|
return $properties;
|
|
|
|
}
|
|
|
|
|
|
|
|
private function buildAddCommentView(PholioMock $mock) {
|
|
|
|
$user = $this->getRequest()->getUser();
|
|
|
|
|
|
|
|
$is_serious = PhabricatorEnv::getEnvConfig('phabricator.serious-business');
|
|
|
|
|
|
|
|
$title = $is_serious
|
|
|
|
? pht('Add Comment')
|
|
|
|
: pht('History Beckons');
|
|
|
|
|
|
|
|
$header = id(new PhabricatorHeaderView())
|
|
|
|
->setHeader($title);
|
|
|
|
|
|
|
|
$action = $is_serious
|
|
|
|
? pht('Add Comment')
|
|
|
|
: pht('Answer The Call');
|
|
|
|
|
|
|
|
$form = id(new AphrontFormView())
|
|
|
|
->setUser($user)
|
2012-11-22 02:27:20 +01:00
|
|
|
->setAction($this->getApplicationURI('/comment/'.$mock->getID().'/'))
|
2012-11-22 02:24:01 +01:00
|
|
|
->setWorkflow(true)
|
|
|
|
->setFlexible(true)
|
|
|
|
->appendChild(
|
|
|
|
id(new PhabricatorRemarkupControl())
|
|
|
|
->setName('comment')
|
2012-11-27 23:06:31 +01:00
|
|
|
->setLabel(pht('Comment'))
|
|
|
|
->setUser($user))
|
2012-11-22 02:24:01 +01:00
|
|
|
->appendChild(
|
|
|
|
id(new AphrontFormSubmitControl())
|
|
|
|
->setValue($action));
|
|
|
|
|
|
|
|
return array(
|
|
|
|
$header,
|
|
|
|
$form,
|
|
|
|
);
|
|
|
|
}
|
|
|
|
|
2012-11-22 02:27:20 +01:00
|
|
|
private function buildTransactionView(
|
|
|
|
array $xactions,
|
|
|
|
PhabricatorMarkupEngine $engine) {
|
|
|
|
assert_instances_of($xactions, 'PholioTransaction');
|
|
|
|
|
|
|
|
$view = new PhabricatorTimelineView();
|
|
|
|
|
|
|
|
foreach ($xactions as $xaction) {
|
|
|
|
$author = $this->getHandle($xaction->getAuthorPHID());
|
|
|
|
|
2012-11-22 02:27:44 +01:00
|
|
|
$old = $xaction->getOldValue();
|
|
|
|
$new = $xaction->getNewValue();
|
|
|
|
|
|
|
|
$xaction_visible = true;
|
|
|
|
$title = null;
|
2012-11-22 02:38:57 +01:00
|
|
|
$type = $xaction->getTransactionType();
|
2012-11-22 02:27:44 +01:00
|
|
|
|
2012-11-22 02:38:57 +01:00
|
|
|
switch ($type) {
|
2012-11-22 02:27:44 +01:00
|
|
|
case PholioTransactionType::TYPE_NONE:
|
|
|
|
$title = pht(
|
|
|
|
'%s added a comment.',
|
|
|
|
$author->renderLink());
|
|
|
|
break;
|
|
|
|
case PholioTransactionType::TYPE_NAME:
|
|
|
|
if ($old === null) {
|
|
|
|
$xaction_visible = false;
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
$title = pht(
|
|
|
|
'%s renamed this mock from "%s" to "%s".',
|
|
|
|
$author->renderLink(),
|
|
|
|
phutil_escape_html($old),
|
|
|
|
phutil_escape_html($new));
|
|
|
|
break;
|
|
|
|
case PholioTransactionType::TYPE_DESCRIPTION:
|
|
|
|
if ($old === null) {
|
|
|
|
$xaction_visible = false;
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
// TODO: Show diff, like Maniphest.
|
|
|
|
$title = pht(
|
|
|
|
'%s updated the description of this mock. '.
|
|
|
|
'The old description was: %s',
|
|
|
|
$author->renderLink(),
|
|
|
|
phutil_escape_html($old));
|
|
|
|
break;
|
|
|
|
case PholioTransactionType::TYPE_VIEW_POLICY:
|
|
|
|
if ($old === null) {
|
|
|
|
$xaction_visible = false;
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
// TODO: Render human-readable.
|
|
|
|
$title = pht(
|
|
|
|
'%s changed the visibility of this mock from "%s" to "%s".',
|
|
|
|
$author->renderLink(),
|
|
|
|
phutil_escape_html($old),
|
|
|
|
phutil_escape_html($new));
|
|
|
|
break;
|
2012-11-22 02:38:57 +01:00
|
|
|
case PholioTransactionType::TYPE_SUBSCRIBERS:
|
|
|
|
$rem = array_diff($old, $new);
|
|
|
|
$add = array_diff($new, $old);
|
|
|
|
|
|
|
|
$add_l = array();
|
|
|
|
foreach ($add as $phid) {
|
|
|
|
$add_l[] = $this->getHandle($phid)->renderLink();
|
|
|
|
}
|
|
|
|
$add_l = implode(', ', $add_l);
|
|
|
|
|
|
|
|
$rem_l = array();
|
|
|
|
foreach ($rem as $phid) {
|
|
|
|
$rem_l[] = $this->getHandle($phid)->renderLink();
|
|
|
|
}
|
|
|
|
$rem_l = implode(', ', $rem_l);
|
|
|
|
|
|
|
|
if ($add && $rem) {
|
|
|
|
$title = pht(
|
|
|
|
'%s edited subscriber(s), added %d: %s; removed %d: %s.',
|
|
|
|
$author->renderLink(),
|
|
|
|
$add_l,
|
|
|
|
count($add),
|
|
|
|
$rem_l,
|
|
|
|
count($rem));
|
|
|
|
} else if ($add) {
|
|
|
|
$title = pht(
|
|
|
|
'%s added %d subscriber(s): %s.',
|
|
|
|
$author->renderLink(),
|
|
|
|
count($add),
|
|
|
|
$add_l);
|
|
|
|
} else if ($rem) {
|
|
|
|
$title = pht(
|
|
|
|
'%s removed %d subscribers: %s.',
|
|
|
|
$author->renderLink(),
|
|
|
|
count($rem),
|
|
|
|
$rem_l);
|
|
|
|
}
|
|
|
|
break;
|
2012-11-22 02:27:44 +01:00
|
|
|
default:
|
|
|
|
throw new Exception("Unknown transaction type '{$type}'!");
|
|
|
|
}
|
|
|
|
|
|
|
|
if (!$xaction_visible) {
|
|
|
|
// Some transactions aren't useful to human viewers, like
|
|
|
|
// the initial transactions which set the mock's name and description.
|
|
|
|
continue;
|
|
|
|
}
|
|
|
|
|
|
|
|
$event = id(new PhabricatorTimelineEventView())
|
|
|
|
->setUserHandle($author);
|
|
|
|
|
|
|
|
$event->setTitle($title);
|
|
|
|
|
|
|
|
if (strlen($xaction->getComment())) {
|
|
|
|
$event->appendChild(
|
|
|
|
$engine->getOutput(
|
|
|
|
$xaction,
|
|
|
|
PholioTransaction::MARKUP_FIELD_COMMENT));
|
|
|
|
}
|
|
|
|
|
|
|
|
$view->addEvent($event);
|
2012-11-22 02:27:20 +01:00
|
|
|
}
|
|
|
|
|
|
|
|
return $view;
|
|
|
|
}
|
|
|
|
|
Add very basic scaffolding for Pholio
Summary:
I'm not going to land this until it's a bit more fleshed out since it would just confuse users, but this is probably more reviewable as a few diffs adding a couple features than one ULTRA-diff adding everything. Implement application basics for Pholio. This does more or less nothing, but adds storage, subscribe, flag, markup, indexing, query basics, PHIDs, handle loads, a couple of realy really basic controllers, etc.
Basic hierarchy is:
- **Moleskine**: Top-level object like a Differential Revision, like "Ponder Feed Ideas".
- **Image**: Each Moleskine has one or more images, like the unexpanded / expanded / mobile / empty states of feed.
- **Transaction**: Comment or edit, like Maniphest. I generally want to move most apps to a transaction model so we can log edits.
- **PixelComment**: Equivalent of an inline comment.
Test Plan: Created a fake object and viewed it.
Reviewers: btrahan, chad
Reviewed By: btrahan
CC: aran, davidreuss
Maniphest Tasks: T2097
Differential Revision: https://secure.phabricator.com/D3817
2012-11-22 02:22:36 +01:00
|
|
|
}
|