revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-25 00:02:41 +01:00
Code Issues Releases Wiki Activity
phorge-phorge/resources/sql/patches/20130621.diffcommentphidmig.php

4 lines
51 B
PHP
Raw Normal View History

Add PHIDs to DifferentialComments Summary: Ref T2222. This adds PHIDs to all Differential comments so I can migrate the inlinecommment table to transaction_comment in the next diff. @wez, this will issue a few million queries for Facebook (roughly, one for each Differential comment ever made). It's safe to skip the `.php` half of the patch, bring Phabricator up normally, and then apply this patch with Phabricator running if that eases the migration, although the next few diffs will probably be downtime-required migrations so maybe it's easier to just schedule some downtime. Test Plan: Ran migration locally. Verified existing comments and new comments received PHIDs. Reviewers: btrahan Reviewed By: btrahan CC: wez, aran Maniphest Tasks: T2222 Differential Revision: https://secure.phabricator.com/D6266
2013-06-22 03:41:14 +02:00
<?php
Undo D6266 (DifferentialComment PHID migration) Summary: Ref T2222. My path forward here wasn't very good -- I was thinking I could set `transactionPHID` for the inline comments as I migrated, but it must be unique and an individual DifferentialComment may have more than one inline comment. Dropping the unique requirement just creates more issues for us, not fewer. So the migration in D6266 isn't actually useful. Undo it -- this can't be a straight revert because some installs may already have upgraded. Test Plan: Ran new migrations, verified the world ended up back in the same place as before (made comments, viewed reivsions). Reviewers: btrahan Reviewed By: btrahan CC: wez, aran Maniphest Tasks: T2222 Differential Revision: https://secure.phabricator.com/D6269
2013-06-24 20:00:35 +02:00
// This patch is unnecessary and was nuked.
Copy permalink