2012-08-02 23:07:21 +02:00
|
|
|
<?php
|
|
|
|
|
|
|
|
final class PhabricatorApplicationAudit extends PhabricatorApplication {
|
|
|
|
|
|
|
|
public function getBaseURI() {
|
|
|
|
return '/audit/';
|
|
|
|
}
|
|
|
|
|
Use application icons for "Eye" menu and Crumbs
Summary:
Issues here:
- Need an application-sized "eye", or a "home" icon for "Phabricator Home".
- Some of the "apps_lb_2x" sliced images are the "_dark_" versions, not the light versions.
- If you slice an application-sized "logout" (power off) icon and application-sized "help" (questionmark in circle) icon I can replace the current menu icons and nearly get rid of "autosprite".
- To replace the icons on /applications/, the non-retina size is "4x", so we'd need "8x" for retina. Alternatively I can reduce the icon sizes by 50%.
- The "Help", "Settings" and "Logout" items currently have a "glowing" hover state, which needs a variant (or we can drop it).
- The /applications/ icons have a white hover state (or we can drop it).
- The 1x application (14x14) icons aren't used anywhere right now, should they be? Maybe in the feed in the future, etc?
- The "apps-2x" and "apps-large" sheets are the same image, but getting them to actually use the same file is a bit tricky, so I just left them separate for now.
Test Plan:
{F26698}
{F26699}
Reviewers: chad
Reviewed By: chad
CC: aran
Maniphest Tasks: T1960
Differential Revision: https://secure.phabricator.com/D4108
2012-12-07 22:37:28 +01:00
|
|
|
public function getIconName() {
|
2012-08-20 23:13:15 +02:00
|
|
|
return 'audit';
|
2012-08-02 23:07:21 +02:00
|
|
|
}
|
|
|
|
|
2014-05-29 21:17:54 +02:00
|
|
|
public function getShortDescription() {
|
|
|
|
return pht('Browse and Audit Commits');
|
|
|
|
}
|
|
|
|
|
(Redesign) Clean up older "Tile" code
Summary:
This does some backend cleanup of the tile stuff, and some general cleanup of other application things:
- Users who haven't customized preferences get a small, specific set of pinned applications: Differential, Maniphest, Diffusion, Audit, Phriction, Projects (and, for administrators, Auth, Config and People).
- Old tile size methods are replaced with `isPinnnedByDefault()`.
- Shortened some short descriptions.
- `shouldAppearInLaunchView()` replaced by less ambiguous `isLaunchable()`.
- Added a marker for third-party / extension applications.
Test Plan: Faked away my preferences and viewed the home page, saw a smaller set of default pins.
Reviewers: chad
Reviewed By: chad
Subscribers: epriestley
Differential Revision: https://secure.phabricator.com/D9358
2014-06-04 00:47:27 +02:00
|
|
|
public function isPinnedByDefault(PhabricatorUser $viewer) {
|
|
|
|
return true;
|
|
|
|
}
|
|
|
|
|
2012-10-10 23:10:24 +02:00
|
|
|
public function getHelpURI() {
|
2014-03-17 23:01:31 +01:00
|
|
|
return PhabricatorEnv::getDoclink('Audit User Guide');
|
2012-10-10 23:10:24 +02:00
|
|
|
}
|
|
|
|
|
2013-02-05 22:46:02 +01:00
|
|
|
public function getEventListeners() {
|
|
|
|
return array(
|
2013-10-22 02:00:21 +02:00
|
|
|
new AuditActionMenuEventListener()
|
2013-02-05 22:46:02 +01:00
|
|
|
);
|
|
|
|
}
|
|
|
|
|
2012-08-05 23:03:39 +02:00
|
|
|
public function getRoutes() {
|
|
|
|
return array(
|
|
|
|
'/audit/' => array(
|
2014-04-27 18:43:05 +02:00
|
|
|
'(?:query/(?P<queryKey>[^/]+)/)?' => 'PhabricatorAuditListController',
|
2012-08-05 23:03:39 +02:00
|
|
|
'addcomment/' => 'PhabricatorAuditAddCommentController',
|
2012-10-06 01:06:16 +02:00
|
|
|
'preview/(?P<id>[1-9]\d*)/' => 'PhabricatorAuditPreviewController',
|
2012-08-05 23:03:39 +02:00
|
|
|
),
|
|
|
|
);
|
|
|
|
}
|
|
|
|
|
2012-10-04 00:46:19 +02:00
|
|
|
public function getApplicationOrder() {
|
Add basic support for new navigation menu
Summary:
Add a new left-side application menu. This menu shows which application you're in and provides a quick way to get to other applications.
On desktops, menus are always shown but the app menu can be collapsed to be very small.
On tablets, navigation buttons allow you to choose between the menus and the content.
On phones, navigation buttons allow you to choose between the app menu, the local menu, and the content.
This needs some code and UI cleanup, but has no effect yet so I think it's okay to land as-is, I'll clean it up a bit as I start integrating it. I want to play around with it a bit and see if it's good/useful or horrible anyway.
Test Plan: Will include screenshots.
Reviewers: vrana, btrahan, chad
Reviewed By: btrahan
CC: aran, alanh
Maniphest Tasks: T1569
Differential Revision: https://secure.phabricator.com/D3223
2012-08-11 16:06:12 +02:00
|
|
|
return 0.130;
|
|
|
|
}
|
|
|
|
|
2012-08-02 23:07:21 +02:00
|
|
|
public function loadStatus(PhabricatorUser $user) {
|
|
|
|
$status = array();
|
|
|
|
|
|
|
|
$phids = PhabricatorAuditCommentEditor::loadAuditPHIDsForUser($user);
|
|
|
|
|
2014-04-27 18:43:05 +02:00
|
|
|
$query = id(new DiffusionCommitQuery())
|
|
|
|
->setViewer($user)
|
|
|
|
->withAuthorPHIDs(array($user->getPHID()))
|
|
|
|
->withAuditStatus(DiffusionCommitQuery::AUDIT_STATUS_CONCERN);
|
|
|
|
$commits = $query->execute();
|
2012-08-02 23:07:21 +02:00
|
|
|
|
2013-02-22 13:57:43 +01:00
|
|
|
$count = count($commits);
|
|
|
|
$type = PhabricatorApplicationStatusView::TYPE_NEEDS_ATTENTION;
|
2012-08-02 23:07:21 +02:00
|
|
|
$status[] = id(new PhabricatorApplicationStatusView())
|
|
|
|
->setType($type)
|
2013-02-22 13:57:43 +01:00
|
|
|
->setText(pht('%d Problem Commit(s)', $count))
|
2012-08-02 23:07:21 +02:00
|
|
|
->setCount($count);
|
|
|
|
|
2014-04-27 18:43:05 +02:00
|
|
|
$query = id(new DiffusionCommitQuery())
|
|
|
|
->setViewer($user)
|
2013-02-22 13:57:43 +01:00
|
|
|
->withAuditorPHIDs($phids)
|
2014-04-27 18:43:05 +02:00
|
|
|
->withAuditStatus(DiffusionCommitQuery::AUDIT_STATUS_OPEN)
|
|
|
|
->withAuditAwaitingUser($user);
|
|
|
|
$commits = $query->execute();
|
2012-08-02 23:07:21 +02:00
|
|
|
|
2014-04-27 18:43:05 +02:00
|
|
|
$count = count($commits);
|
2013-02-22 13:57:43 +01:00
|
|
|
$type = PhabricatorApplicationStatusView::TYPE_WARNING;
|
2012-08-02 23:07:21 +02:00
|
|
|
$status[] = id(new PhabricatorApplicationStatusView())
|
|
|
|
->setType($type)
|
2013-02-22 13:57:43 +01:00
|
|
|
->setText(pht('%d Commit(s) Awaiting Audit', $count))
|
2012-08-02 23:07:21 +02:00
|
|
|
->setCount($count);
|
|
|
|
|
|
|
|
return $status;
|
|
|
|
}
|
|
|
|
|
|
|
|
}
|