phorge-phorge/resources/sql/patches/testdatabase.sql

CREATE TABLE {$NAMESPACE}_harbormaster.harbormaster_scratchtable (
  `id` int unsigned NOT NULL AUTO_INCREMENT PRIMARY KEY,
  `data` varchar(64) NOT NULL collate utf8_bin,
  `dateCreated` int unsigned NOT NULL,
  `dateModified` int unsigned NOT NULL,
  KEY (data)
) ENGINE=InnoDB DEFAULT CHARSET=utf8;
Remove PHID database, add Harbormaster database Summary: - We currently write every PHID we generate to a table. This was motivated by two concerns: - Understanding Data: At Facebook, the data was sometimes kind of a mess. You could look at a random user in the ID tool and see 9000 assocs with random binary data attached to them, pointing at a zillion other objects with no idea how any of it got there. I originally created this table to have a canonical source of truth about PHID basics, at least. In practice, our data model has been really tidy and consistent, and we don't use any of the auxiliary data in this table (or even write it). The handle abstraction is powerful and covers essentially all of the useful data in the app, and we have human-readable types in the keys. So I don't think we have a real need here, and this table isn't serving it if we do. - Uniqueness: With a unique key, we can be sure they're unique, even if we get astronomically unlucky and get a collision. But every table we use them in has a unique key anyway. So we actually get pretty much nothing here, except maybe some vague guarantee that we won't reallocate a key later if the original object is deleted. But it's hard to imagine any install will ever have a collision, given that the key space is 36^20 per object type. - We also currently use PHIDs and Users in tests sometimes. This is silly and can break (see D2461). - Drop the PHID database. - Introduce a "Harbormaster" database (the eventual CI tool, after Drydock). - Add a scratch table to the Harbormaster database for doing unit test meta-tests. - Now, PHID generation does no writes, and unit tests are isolated from the application. - @csilvers: This should slightly improve the performance of the large query-bound tail in D2457. Test Plan: Ran unit tests. Ran storage upgrade. Reviewers: btrahan, vrana, jungejason Reviewed By: btrahan CC: csilvers, aran, nh, edward Differential Revision: https://secure.phabricator.com/D2466 2012-05-20 23:46:01 +02:00			`CREATE TABLE {$NAMESPACE}_harbormaster.harbormaster_scratchtable (`
			`id` int unsigned NOT NULL AUTO_INCREMENT PRIMARY KEY,
			`data` varchar(64) NOT NULL collate utf8_bin,
			`dateCreated` int unsigned NOT NULL,
			`dateModified` int unsigned NOT NULL,
			`KEY (data)`
			`) ENGINE=InnoDB DEFAULT CHARSET=utf8;`